Closed Bug 1644301 Opened 4 years ago Closed 4 years ago

Downloaded PDFs that have a non-'application/pdf' mimetype should be opened in Firefox first

Categories

(Firefox :: File Handling, defect)

Product:
Firefox
Component:
File Handling
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 79
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox77 --- unaffected
firefox78 + verified
firefox79 + verified

People

(Reporter: jaws, Assigned: jaws)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1644301 - Open PDF in Firefox if the file extension is PDF even if the mimetype isn't application/pdf.
(deleted), text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details
No description provided.
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/117181d42308 Open PDF in Firefox if the file extension is PDF even if the mimetype isn't application/pdf. r=mstriemer

[Tracking Requested - why for this release]: regression fix for new feature shipping in Firefox 78

status-firefox77: --- → unaffected
status-firefox78: --- → affected
tracking-firefox78: --- → ?
Keywords: regression
Summary: Downloaded PDFs file that have a non-'application/pdf' mimetype should be opened in Firefox first → Downloaded PDFs that have a non-'application/pdf' mimetype should be opened in Firefox first

https://hg.mozilla.org/mozilla-central/rev/117181d42308

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Comment on attachment 9155145 [details]
Bug 1644301 - Open PDF in Firefox if the file extension is PDF even if the mimetype isn't application/pdf.

Beta/Release Uplift Approval Request

  • User impact if declined: Inconsistent behavior with opening downloaded PDFs that the user will not be able to predict.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Visit https://smallpdf.com/shared#pt=02fdd17c-5a41-4a2c-a381-e094422dca8d and Save the PDF from the "Download" link
    Click on the saved PDF in the downloads panel to open it
    The PDF should be opened in Firefox and not an external application
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Adds to existing code a check for file extension if the mimetype isn't application/pdf
  • String changes made/needed: None
Attachment #9155145 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Verified - Fixed in latest Nightly 79.0a1 (build id: 20200609151649) using Windows 10. The saved PDF is opened in firefox in the same tab as the page from which the PDF was downloaded.

status-firefox79: fixed → verified

Comment on attachment 9155145 [details]
Bug 1644301 - Open PDF in Firefox if the file extension is PDF even if the mimetype isn't application/pdf.

approved for 78.0b6

Attachment #9155145 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - Fixed in latest Beta 78.0b6 (build id: 20200611104559). The saved PDF is opened in the same browser, in firefox.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox78: fixed → verified
Flags: qe-verify+
Depends on: 1646718
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: