Open Bug 1644302 Opened 4 years ago Updated 4 years ago

Form History autocomplete popup does not show in forms with Shadow DOM

Categories

(Toolkit :: Form Manager, defect, P2)

79 Branch
defect

Tracking

()

Tracking Status
thunderbird_esr60 --- unaffected
thunderbird_esr68 --- wontfix
firefox-esr68 --- wontfix
firefox-esr78 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- fix-optional

People

(Reporter: bdanforth, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached file form_history_shadow_dom_bug.txt (deleted) —

Similar to Bug 1629226, it is likely that much of the Form Manager does not work when login forms are in a Shadow DOM.

I encountered one example of this while working on Bug 1643163, where the Form History autocomplete popup does not show when the username field is in its own Shadow Root. My best guess is that the Form Manager is not finding the <form> element in this situation.

STR
In a test profile for toolkit/components/passwordmgr/test/browser/form_basic.html:

  1. Load the page in a HTTPS context.
  • I set up a local HTTPS Apache server to achieve this.
  1. Delete any logins for the site via about:logins.
  2. Enter in a fake username value and click the Submit Query button. After the form is submitted, the page should reload with an empty username field.
  3. Focus on the username field.
  4. Observe the Form History autocomplete popup, with the username value previously entered as an option.
  5. Repeat steps 1-4 in the same profile with toolkit/components/passwordmgr/test/mochitest/form_basic_shadow_DOM_each_field_in_its_own_shadow_root.html (from Bug 1638587).
  6. Observe that upon focusing the username field, there is no Form History autocomplete popup shown.

Expected results
There is a Form History autocomplete popup for the form_basic_shadow_DOM_each_field_in_its_own_shadow_root.html page.

Actual results
There is no Form History autocomplete popup for the form_basic_shadow_DOM_each_field_in_its_own_shadow_root.html page.

Logs
Attached are the logs generated from these STR by running Firefox with MOZ_LOG="satchel:5" for C++ logging and setting browser.formfill.debug to true in about:config for JS logging.

Thanks! Looks like it's saving at least:

satchelFormListener: sending entries to parent process for form form-basic

Severity: -- → S3
Keywords: regression
Priority: -- → P2
Regressed by: shadowdom-dom
Has Regression Range: --- → yes

I'm a bit confused about the regressing bug here - what versions are affected based on that dependency?

Flags: needinfo?(MattN+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: