Do not use Clone on CloneableAutoTArray
Categories
(Core :: XPCOM, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox77 | --- | unaffected |
firefox78 | --- | wontfix |
firefox79 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
As was mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1626570#c118, there were some performance regressions in connection with the introduction of CopyableAutoTArray
, in particular with WebAudio.
This is likely to be caused by missed optimization / copy elision opportunities due to the calling of the base class' Clone
method which returns an AutoTArray
instead of a CopyableAutoTArray
. Changing this to an ordinary copy reverts the performance regression as can be observed here:
CopyableAutoTArray
should be deleted to avoid doing this accidentally as in this case.
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
Comment 3•4 years ago
|
||
Set release status flags based on info from the regressing bug 1626570
Assignee | ||
Comment 4•4 years ago
|
||
I am not sure if this should be regarded a defect. It does not fix a functional issue, but reverts a performance regression, which I am not sure is significant enough to be regarded a defect.
Comment 7•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Description
•