Closed
Bug 1644472
Opened 4 years ago
Closed 4 years ago
Optimize some RegExp intrinsics in CacheIR and Warp
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
I have some patches for IsRegExpObject and RegExp{Matcher,Searcher,Tester} that improve Warp perf on octane-regexp.
|
Assignee | |
Comment 1•4 years ago
|
||
I tried to keep this generic in case we add a similar function for another Class
in the future.
|
|
Assignee | |
Comment 2•4 years ago
|
||
The CacheIR code is just a VM call that's slightly faster than the CallNative path.
The main benefit is that this lets Warp use the optimized regexp stubs.
At some point it would be nice to call the same code stubs from CacheIR.
Depends on D79040
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D79041
|
|
Assignee | |
Comment 4•4 years ago
|
||
These just do a Shape guard against a Shape stored in the Realm. If the guard
fails we do a callWithABI to a function that updates the shape.
Depends on D79263
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5845925ecf9
part 1 - Optimize IsRegExpObject intrinsic in CacheIR and Warp. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/f5d92b5d503e
part 2 - Optimize RegExpMatcher, RegExpSearcher, RegExpTester intrinsics in CacheIR and Warp. r=iain
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57fb53405c05
part 3 - Optimize SubstringKernel intrinsic in CacheIR and Warp. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/798a5cd87e54
part 4 - Optimize RegExpPrototypeOptimizable and RegExpInstanceOptimizable intrinsics. r=iain
|
|
Assignee | |
Updated•4 years ago
|
Keywords: leave-open
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/57fb53405c05
https://hg.mozilla.org/mozilla-central/rev/798a5cd87e54
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•