Closed
Bug 1644523
Opened 4 years ago
Closed 4 years ago
Optimize UnsafeGetReservedSlot intrinsic in CacheIR and Warp
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
In baseline we can't really optimize the typed variant because we have to return boxed values anyway.
(Ion does not use Call ICs so MOZ_CRASH for now at least)
|
||
Updated•4 years ago
|
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•4 years ago
|
||
Using MGuardValue for guardSpecificInt32 is a bit lazy, because it will always box the value.
Right now this doesn't matter, because the value should always be constant so the instruction should be folded away.
We can add all the required MIR and LIR instructions when we ever actually use this.
Depends on D78949
|
|
||
Updated•4 years ago
|
Attachment #9155385 -
Attachment description: Bug 1644523 - Transpile LoadFixedSlotTyped and GuardSpecificInt32. r?iain → Bug 1644523 - Transpile LoadFixedSlotTyped r?iain
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d321c1702bc
Optimize UnsafeGetReservedSlot intrinsic in CacheIR. r=iain
https://hg.mozilla.org/integration/autoland/rev/fdbfb24491c8
Transpile LoadFixedSlotTyped r=iain
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d321c1702bc
https://hg.mozilla.org/mozilla-central/rev/fdbfb24491c8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•