Closed Bug 1645331 Opened 4 years ago Closed 4 years ago

Catch asyncClose exceptions and mark the database as closed

Categories

(Toolkit :: Storage, defect, P1)

Product:
Toolkit
Component:
Storage
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Iteration:
79.2 - June 15 - June 28
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1645331 - Catch asyncClose exceptions and mark the database as closed. r=lina
(deleted), text/x-phabricator-request
Details

Sqlite.jsm doesn't catch asyncClose() exceptions, and thus if they happen the close promise is never resolved and we may crash on shutdown.

Blocks: 1326309
Iteration: --- → 79.2 - June 15 - June 28
Points: --- → 1
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/360d257d80c8 Catch asyncClose exceptions and mark the database as closed. r=lina

https://hg.mozilla.org/mozilla-central/rev/360d257d80c8

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

It looks like this cut shutdown crashes reported in bug 1326309 by a lot. \o/

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: