Crash in [@ gfxDWriteFontList::CreateFontEntry]
Categories
(Core :: Layout: Text and Fonts, defect, P2)
Tracking
()
People
(Reporter: over68, Assigned: jfkthame)
References
Details
Crash Data
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Steps to reproduce:
- Set
gfx.e10s.font-list.shared
totrue
. - Restart Firefox.
- Download Font Loader.
- Download and extracts the archive.
- Open https://emojipedia.org/emoji/ in three tabs.
- Open the Font Loader, Click on the Add Fonts button, Select the extracted font files then click Open.
- Click on the Load button then Unload.
- Open https://emojipedia.org/emoji/ in new tab.
- Switch between tabs.
See https://youtu.be/wiatFCir-uM
Actual results:
The tab crashed when clicking on the Unload button then switch between tabs.
Crash report: bp-4e7babc2-b0a2-41b7-88d9-e9c530200614
0 xul.dll gfxDWriteFontList::CreateFontEntry gfx/thebes/gfxDWriteFontList.cpp:980
1 xul.dll gfxPlatformFontList::GetOrCreateFontEntry gfx/thebes/gfxPlatformFontList.cpp:1300
2 xul.dll mozilla::fontlist::Family::SearchAllFontsForChar gfx/thebes/SharedFontList.cpp:372
3 xul.dll gfxPlatformFontList::GlobalFontFallback gfx/thebes/gfxPlatformFontList.cpp:1005
4 xul.dll gfxPlatformFontList::SystemFindFontForChar gfx/thebes/gfxPlatformFontList.cpp:885
5 xul.dll gfxFontGroup::WhichSystemFontSupportsChar gfx/thebes/gfxTextRun.cpp:3467
6 xul.dll gfxFontGroup::FindFontForChar gfx/thebes/gfxTextRun.cpp:3101
7 xul.dll gfxFontGroup::InitScriptRun<char16_t> gfx/thebes/gfxTextRun.cpp:2562
8 xul.dll gfxFontGroup::MakeTextRun gfx/thebes/gfxTextRun.cpp:2356
9 xul.dll BuildTextRunsScanner::BuildTextRunForFrames layout/generic/nsTextFrame.cpp:2527
Assignee | ||
Comment 1•4 years ago
|
||
Ah, I see what's broken here... if the FindFamilyName
call at https://hg.mozilla.org/mozilla-central/file/1d3eb5f9e1b6e25fa8f6cad8843ae3feef012ca2/gfx/thebes/gfxDWriteFontList.cpp#l970 fails, we leave family
as null, but fail to check that properly and bail out of the method. We need to fix up the failure handling here.
Assignee | ||
Comment 2•4 years ago
|
||
Tryserver build that I think should fix the issue here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4f29ab6711689b31368188039d890dd3629264
Assignee | ||
Comment 3•4 years ago
|
||
Comment 5•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 6•4 years ago
|
||
I reproduced the issue on Firefox Nightly (2020-06-13) under Windows 10 by using the STR from Comment 0.
The issue is fixed as I was unable to crash the tabs on Firefox 80.0a1 (2020-07-06) and Firefox 79.0b4 under Windows 10.
Description
•