Closed Bug 1645732 Opened 4 years ago Closed 4 years ago

Collect Linux back end telemetry data

Categories

(Core :: Graphics, enhancement)

Product:
Core
Component:
Graphics
Platform:
Unspecified
Linux
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: stransky, Assigned: mkaply)

References

Details

Attachments

(2 files, 1 obsolete file)

Data collection form
(deleted), text/plain
chutten
: data-review+
Details
Bug 1645732 - Add telemetry for Linux window protocol.
(deleted), text/x-phabricator-request
Details

Collect Linux back end telemetry data (Wayland/X11) to better plan Linux development.
It's at about:support, "Window Protocol" and can be "Wayland", "Wayland/drm", "x11" for now.

Data collections are usually implemented by the components doing the collection. Looks like Core:Graphics is the right place to do that. In bug 1554540 it was added to about:support.

Component: Telemetry → Graphics
Product: Toolkit → Core

https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/toolkit/content/aboutSupport.js#603-604
Please include windowProtocol and, if possible, desktopEnvironment in crash reports as well.

Depends on: 1554540, 1602819
OS: Unspecified → Linux
Severity: -- → S3

Here's the process for this.

https://wiki.mozilla.org/Firefox/Data_Collection

We'll need to do a data collection request. I'll own working on that.

Attached file Data collection form (obsolete) (deleted) —
Attachment #9157336 - Flags: data-review?(mozilla)
Attachment #9157336 - Flags: data-review?(mozilla) → data-review?(chutten)
Comment on attachment 9157336 [details] Data collection form There is a new version of the Data Review Request form: https://github.com/mozilla/data-review/blob/master/request.md Of specific notice is that there is a new question about where documentation for this collection will live. (( Otherwise the request looks fine. This'll be an easy r+ on the new form ))
Attachment #9157336 - Flags: data-review?(chutten)
Attached file Data collection form (deleted) —

I think this is right...

Attachment #9157336 - Attachment is obsolete: true
Attachment #9165777 - Flags: data-review?(chutten)
Comment on attachment 9165777 [details] Data collection form So sorry for the delay, somehow I missed your request. DATA COLLECTION REVIEW RESPONSE: Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate? Yes. Is there a control mechanism that allows the user to turn the data collection on and off? Yes. This collection is Telemetry so can be controlled through Firefox's Preferences. If the request is for permanent data collection, is there someone who will monitor the data over time? Yes, :mkaply is responsible. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under? Category 1, Technical. Is the data collection request for default-on or default-off? Default on for all channels. Does the instrumentation include the addition of any new identifiers? No. Is the data collection covered by the existing Firefox privacy notice? Yes. Does there need to be a check-in in the future to determine whether to renew the data? No. This collection is permanent. --- Result: datareview+
Attachment #9165777 - Flags: data-review?(chutten) → data-review+

crash report annotation is here:

https://searchfox.org/mozilla-central/source/widget/GfxInfoX11.cpp#55

I think I can add telemetry here:

https://searchfox.org/mozilla-central/source/widget/GfxInfoX11.cpp#693

any advice on where to put this chutten? I guess I'm looking for something that only happens once.

Most of this is called from FindBlocklistedDeviceInList. I have no idea how often that gets called.

Martin, is this something one of your team can take on? We have permission to do it now and I can help with getting the code together, just don't know where to put it.

Flags: needinfo?(stransky)
Flags: needinfo?(chutten)

I'm afraid I don't know gfx code all that well, so I can't point to any place that's called once. (and then to find one that also has easy access to the backend name). But when you do, I presume you're planning on stuffing it in a String Scalar? You won't have any problems accessing that from wherever you are (even if you have to do it from inside the gpu process)

Flags: needinfo?(chutten)

(In reply to Mike Kaply [:mkaply] from comment #8)

https://searchfox.org/mozilla-central/source/widget/GfxInfoX11.cpp#693

any advice on where to put this chutten? I guess I'm looking for something that only happens once.

Most of this is called from FindBlocklistedDeviceInList. I have no idea how often that gets called.

Martin, is this something one of your team can take on? We have permission to do it now and I can help with getting the code together, just don't know where to put it.

https://searchfox.org/mozilla-central/source/widget/GfxInfoX11.cpp#693 is a good place, it's called only once after Firefox start.
Yes, I can review/create the patch if you give me some hints how to export the data.

Thanks.

Flags: needinfo?(stransky)

Martin: I think this patch will do it.

The way to test is to build and then start Firefox and go to about:telemetry.

Search on LINUX_WINDOW_PROTOCOL or Wayland and hopefully you'll see something.

Flags: needinfo?(stransky)

(In reply to Mike Kaply [:mkaply] from comment #12)

Martin: I think this patch will do it.

The way to test is to build and then start Firefox and go to about:telemetry.

Search on LINUX_WINDOW_PROTOCOL or Wayland and hopefully you'll see something.

Yes, I do see 'gfx.linux_window_protocol' is 'wayland/drm' in my case.

Flags: needinfo?(stransky)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Pushed by mozilla@kaply.com: https://hg.mozilla.org/integration/autoland/rev/e55422de3781 Add telemetry for Linux window protocol. r=chutten,aosmond

https://hg.mozilla.org/mozilla-central/rev/e55422de3781

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: