Closed
Bug 1645794
Opened 4 years ago
Closed 4 years ago
dom/html/reftests/autofocus/textarea-* testcases are unreliable due to a layout sizing bug
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
See bug 1645773 for standalone testcase: the use of background-color in the :focus style for the textarea tests here makes them unreliable (dependent on exact timing of reflows etc).
To paper over this issue for the sake of the autofocus tests here, I propose replacing the use of background-color in the styles with a different property that will not affect the sizing. Obviously, the underlying layout issue remains open, and should be fixed, but these tests can be made independent of it.
|
Assignee | |
Comment 1•4 years ago
|
||
See Layout bug 1645773 for details. This patch works around the unreliability
by styling the text color instead of background, which has no effect on the
element sizing.
|
||
Updated•4 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9156699 -
Attachment description: Bug 1645794 - Don't use background-color in textarea's :focus styling, because it causes unreliable sizing. r=emilio → Bug 1645794 - Set -moz-appearance:none on textareas, to avoid unreliable sizing when setting/removing background. r=emilio
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90b56445e97a
Set -moz-appearance:none on textareas, to avoid unreliable sizing when setting/removing background. r=emilio
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•