Reverse-elfhack code in android xpcshell harness is no longer used
Categories
(Testing :: XPCShell Harness, enhancement, P1)
Tracking
(firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497
Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.
Comment 1•4 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #0)
Bug 1389805 added xpcshell harness support for reverse-elfhack, but I find it is no longer being used, neither in CI nor with local builds; this condition is never positive, with current builds:
https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/testing/xpcshell/remotexpcshelltests.py#497Let's remove that code to avoid the file access overhead, and also incidentally, avoid a py3 incompatibility.
gbrown: I happen to know that the perf team is having a hard time symbolicating GeckoView on ARMv7: see this issue. Is it possible that this reverse-elfhack
step is required? (I have never heard of this step until now so I know nothing.)
acreskey: this might be relevant to your interests.
Assignee | ||
Comment 2•4 years ago
|
||
I don't think so. We only ever used it for xpcshell.
Assignee | ||
Comment 3•4 years ago
|
||
Remove some dead code from remote xpcshell harness.
Assignee | ||
Comment 4•4 years ago
|
||
Also verified crash reports after this change:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2620cc9e3da64e8db33ff976f7000732ea7e67c3
Comment 6•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•