Closed Bug 1646289 Opened 4 years ago Closed 3 years ago

Replace uuid from TabTarget.id with unique window identifiers as used by WebDriver

Categories

(Remote Protocol :: CDP, task, P2)

Product:
Remote Protocol
Component:
CDP
Type:
task
Points:
2

Tracking

(firefox99 fixed)

Status:
RESOLVED FIXED
Milestone:
99 Branch
Tracking Flags:
Tracking Status
firefox99 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [bidi-m3-mvp])

Attachments

(2 files, 1 obsolete file)

Bug 1646289 - [CDP] Share unique TabTarget id with WebDriver.
(deleted), text/x-phabricator-request
Details
Bug 1646289 - [CDP] Compare by target id and not browsing context id.
(deleted), text/x-phabricator-request
Details

With bug 1580766 fixed there is now a stable BrowsingContext.browserId identifier available which never changes in case of process changes. It's uniqueness allows us to get rid of the uuid and to make use of the id instead.

Note that it is also available via linkedBrowser.browserId.

The Target.id is a string, so when implementing the above changes we have to convert the id to a string when returning the value, and vice versa when receiving a command.

Assignee: nobody → gl
Status: NEW → ASSIGNED
Fission Milestone: --- → M6c

Gabriel, could you please finalize the patch to close this bug?

Flags: needinfo?(gl)

Someone from our team will have to finish it eventually.

Assignee: gl → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(gl)
Fission Milestone: M6c → M7
Whiteboard: dt-fission-future

Honza said this is not part of dt-fission-m3-mvp and is not considered Fission M7 blocker.

Fission Milestone: M7 → ---

dt-fission-future don't need to block Fission MVP.

Fission Milestone: --- → Future
Depends on: 1680479
Component: CDP: Target → CDP
Depends on: 1693993

Actually to be in sync with WebDriver we will have to keep our own cache of uuids around that are based on the permanentKey for each browser.

Summary: Replace uuid from TabTarget.id with BrowsingContext.browserId → Replace uuid from TabTarget.id with unique window identifiers as used by WebDriver
Whiteboard: dt-fission-future → [bidi-m1-mvp]
Points: --- → 2
Depends on: 1691501
Whiteboard: [bidi-m1-mvp] → [bidi-m2-mvp]
Priority: P3 → --

It's not clear atm if Puppeteer will get started with quarter with BiDi. As such moving to the reserved list for now.

Priority: -- → P3
Blocks: 1691493
Priority: P3 → --
Whiteboard: [bidi-m2-mvp] → [bidi-m3-mvp]
Fission Milestone: Future → ---
Depends on: 1747222

We won't need it for M3 and will come back to it once it's clear how to integrate CDP.

Whiteboard: [bidi-m3-mvp]
Attachment #9158070 - Attachment is obsolete: true
Blocks: 1750494

With bug 1680479 fixed we should now use the unique id for tab browsers as generated for WebDriver BiDi.

Blocks: 1750065
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [bidi-m3-mvp]
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9fc6ad9a775 [CDP] Share unique TabTarget id with WebDriver. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/caca2a1d5cce [CDP] Compare by target id and not browsing context id. r=webdriver-reviewers,jdescottes

https://hg.mozilla.org/mozilla-central/rev/a9fc6ad9a775
https://hg.mozilla.org/mozilla-central/rev/caca2a1d5cce

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox99: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: