Closed Bug 1646539 Opened 4 years ago Closed 4 years ago

Fix GetInProcessParent usage in nsGlobalWindowOuter::PopupWhitelisted and friends

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Project Flags:
Fission Milestone M6b
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: kmag, Assigned: farre)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Bug 1646539 - Part 1: Test cross origin popup permissions. r=nika
(deleted), text/x-phabricator-request
Details
Bug 1646539 - Part 2: Add field on WindowContext tracking popup permission. r=nika
(deleted), text/x-phabricator-request
Details
Bug 1646539 - Part 3: Update test to work with xorigin popup blocking. r=smaug
(deleted), text/x-phabricator-request
Details
Bug 1646539 follow-up - Add missing #include to un-break the Thunderbird build. r?nika
(deleted), text/x-phabricator-request
Details
Bug 1646539 - Part 3. Fix compilation. r?farre,nika
(deleted), text/x-phabricator-request
Details

There may be an existing bug for making the popup blocker Fission-compatible, in which case this should be folded into it.

Severity: -- → N/A
Type: defect → task
Type: task → defect
Summary: Fix GetInProcessParent usage in GetInProcessParent → Fix GetInProcessParent usage in nsGlobalWindowOuter::PopupWhitelisted and friends

Assigning to farre as he already owns Bug 1579847

Assignee: nobody → afarre
Severity: N/A → S2
Status: NEW → ASSIGNED
Fission Milestone: --- → M6b
Priority: -- → P2

Popup permissions initialized with the result of checking if the
constructing WindowContext's principal is allowed to open a popup. The
field is updated for all WindowContexts sharing a principal whenever
the popup permission for that nsIPrincipal changes.

Depends on D86377

Attachment #9168822 - Attachment description: Bug 1646539 - Part 1: Test cross origin popup permissions. r=nika,baku → Bug 1646539 - Part 1: Test cross origin popup permissions. r=nika
Attachment #9168823 - Attachment description: Bug 1646539 - Part 2: Add field on WindowContext tracking popup permission. r=nika,baku → Bug 1646539 - Part 2: Add field on WindowContext tracking popup permission. r=nika

Changing popup permissions now need to synchronize across
participating content processes before becoming active.

Depends on D86378

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=Fl4ymNvcT62HYznnBGbS-g.0&revision=9f20c8c9256d9bce62bdf5ec640c7a81dd3e548f

https://treeherder.mozilla.org/logviewer.html#?job_id=312802582&repo=try is failing heavily, but this is the same as bug 1578794, and not related to this patch, but the test hits it a bit too much on debug, which is why I'll disable this new test for debug.

Neha, I've queued landing. If it doesn't land, or bounces I'll see if I can get an hour tomorrow. Otherwise if someone else can get it landed it would be great.

Flags: needinfo?(nkochar)
Blocks: 1647454
Pushed by afarre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/60935e46d8ad Part 1: Test cross origin popup permissions. r=nika https://hg.mozilla.org/integration/autoland/rev/c17230c7df92 Part 2: Add field on WindowContext tracking popup permission. r=nika https://hg.mozilla.org/integration/autoland/rev/f57fff8248b5 Part 3: Update test to work with xorigin popup blocking. r=smaug

https://hg.mozilla.org/mozilla-central/rev/60935e46d8ad
https://hg.mozilla.org/mozilla-central/rev/c17230c7df92
https://hg.mozilla.org/mozilla-central/rev/f57fff8248b5

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/integration/autoland/rev/a56436c11321 follow-up - Add missing #include to un-break the Thunderbird build. r=nika

BrowserContext is only fast declared here.
To avoid having to include the full header, move it out of the header.

Flags: needinfo?(nkochar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: