Closed
Bug 1646975
Opened 4 years ago
Closed 4 years ago
Warp: Transpile ToString instructions
Categories
(Core :: JavaScript Engine: JIT, task)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
These instructions are used for string concatenation. This is a massive win for six-speed, which concatenates int32s with strings.
I have one additional patch that adds specialization to MToString, which means we will only unbox the types observed by CacheIR. However I mostly convinced myself that current uses are safe. We already disallow everything with side-effects. So we only really have to worry about + being wrongly implemented as concat. I think this can't really happen, because we always have at least one side as GuardToString transpiled to a string unbox instruction.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cc336f1c478f
Transpile ToString instructions. r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•