Classic theme menus doesnt really recpect gtk theme colors on the syetm where as buttons & tab colors respect it. check the screenshots. Using Mozilla 2002082610 on Linux

Menus showing the colors not the gtk theme colors

bug 164581?

Looks like it, yes.

We're going to need some nsITheme love here.

Note that the menu theming involves more than just "colors". Using a distinctive GTK theme like BumbleBee makes it easier to spot the differences.

I downloaded an i686 nightly 20021027. The features as advertised on the Mozilla web site say that GTK widgets are correctly picked up using the Classic theme. The GTK widgets are working properly but the background colors for GTK widgets such as menubars, windows, etc. are not picking up the background colors correctly for GTK widgets I have set in my system which is Mandrake 9.0. I have checked several GTK apps on my system and verified that the background color is inherited correctly. I noticed that the latest Phoenix build does the GTK background colors correctly within the default Phoenix theme. Run Phoenix and Mozilla 1.2b side by side and you will see the widget background color problem.Until this bug gets fixed maybe the Mozilla.org web site docs should be changed to read GTK support is mostly available except background colors for widgets.

most of what this bug covers is fixed by the checkin for bug 118296 There's still a problem with the text colour for highlighted menu items. I'll have a patch for that coming up. Not 100% sure if it is the right fix though.

Comment on attachment 142911 [details] [diff] [review] highlighttext should be text[GTK_STATE_SELECTED] not fg[GTK_STATE_SELECTED] ? ok, my bad, this patch doesn't fix the issue (I must have been seeing things).

then again, it does... I forgot to restart the firefox the second time I tested. My patch is only for gtk2, not sure if gtk1 needs this change as well.

Comment on attachment 142971 [details] [diff] [review] highlight/highlighttext should use base/text not bg/fg seeking review

Comment on attachment 142971 [details] [diff] [review] highlight/highlighttext should use base/text not bg/fg After chatting with pch on irc about this. I now know that this is this is wrong. it seems that the menu problem is harder than I thought, after taking a look at some gtk2 themes, I think we have to actually get a menu and menuitem to actually get the colours.

seems like for gtk2 we need a MenuHighlight/MenuHighlightText that corresponds to bg[GTK_STYLE_PRELIGHT]/fg[GTK_STYLE_PRELIGHT] of a GtkStyle of a GtkMenuItem. As the PRELIGHT value for menus can be different from the default PRELIGHT value.

re-assingning to bryner. may have a dup of this that he is working on.

Can somebody guess which release will fix this problem? The impact is not important, but already at least 8 reports from Debian's BTS were forwarded here, and there was no activity since over 14 months.

I think the menu highlighting problem in Mozilla is fixed by bug 251492, and the same problem in Firefox/Thunderbird is open in bug 244955. Is there anything else left unresolved in this bug report, or can it be RESOLVED FIXED now?

There still are a few small glitches left. At least two are visible in these screenshots with Human theme: 1) The arrow, which indicates that a submenu is available, turns white when an appropriate menu item is hovered. In a native GTK program (gedit) they don't change color. 2) A radio button is way smaller in Firefox menu than in gedit menu.

I think the last glitches of comment 20 are resolved now, since the arrow is natively styled; the radio buttons are WFM in current trunk. Rimas, could you check again and tell if I can close this bug ?