Closed Bug 1647889 Opened 4 years ago Closed 4 years ago

Show different Urlbar placeholder while visual indicator is showing

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement
Points:
3

Tracking

()

RESOLVED FIXED
81 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Status
firefox81 --- fixed

People

(Reporter: bugzilla, Assigned: adw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We need a new string from UX/Content Stategy. We should be aware of l10n challenges.

Severity: -- → S3
Priority: -- → P2
Keywords: blocked-ux

This is covered in the most recent UX spec, linked in the metabug. I'm raising the priority since Product would like this address ASAP, although this doesn't block bug 1658326.

We're going to show "Enter search terms" as the placeholder unless the engine is a "general-purpose" search engine. In that case, we will show "Search the Web". General-purpose search engines include Google, Bing, DuckDuckGo, Yandex, and Baidu. Others could be added in the future.

Speaking with engineering, the best way to approach this would be to introduce a new static list of engine categories, including but not limited to:

  • general
  • travel
  • products
  • news
  • knowledge
  • code
  • other

"other" will include any engine for which we can't determine a category, including OpenSearch engines and WebExtension engines (for now). In the future, we might want to allow WebExtensions to declare a category for their engine, especially once these categories do something useful.

Assigning a category to every built-in engine doesn't have to be a part of this bug. But introducing these categories now will help with vertical search work in the future. We will show the "Search the Web" placeholder string for any "general" category search engine.

Keywords: blocked-ux
Priority: P2 → P1
Summary: Show Urlbar placeholder while visual indicator is showing → Show different Urlbar placeholder while visual indicator is showing
Assignee: nobody → adw
Status: NEW → ASSIGNED
Iteration: --- → 81.2 - Aug 10 - Aug 23

Bug 1640054 also needs to store some new metadata for search engines, and I think we've settled on remote settings for it, although we discuss a few possibilities. But that might not easily fit into a scheme that allows random third-party engines to declare their categories. Anyway, I mention it so we're aware of that commonality.

This is the simplest possible way to fix this bug in the interest of landing
ASAP. It keeps a hardcoded list of engines that search the web.

Blocks: 1658661
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a8bd5831171 Show different Urlbar placeholder while visual indicator is showing. r=harry,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Blocks: 1697477
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: