Closed Bug 1647927 Opened 4 years ago Closed 4 years ago

Evaluate replacing tab-to-search results when a more specific keyword is typed

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
83 Branch
Iteration:
83.1 - Sept 21 - Oct 4
Tracking Status
firefox83 --- verified

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

We should consider the case of when a user has two engine aliases registered, one of which begins with the other in its entirely. For example, they have Amazon registered as "a" and AliExpress registered as "ali". When the user types "a" we should show the Amazon tab-to-search result. But when they then type "l", we should replace the Amazon tab-to-search result with the AliExpress one. We want to be sure that we don't reanimate the tab-to-search result to avoid annoyance.

Severity: -- → S3
Priority: -- → P3
Priority: P3 → P2
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 83.1 - Sept 21 - Oct 4

The description talks about engine aliases, but I think there was some confusion between the specified behaviour of tab-to-search results appearing for autofilled engine domains and bug 1647901, which proposes different behaviour. My patch only addresses the autofill case. For example, when the user has amazon.com and aliexpress.com registered as search engines and has both in their browsing history. If they type "a", we should show the tab-to-search engine for whichever domain is autofilled. As they continue typing and the other domain is autofilled, we show the other tab-to-search engine.

Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aa9339a3e611 Return an array from UrlbarSearchUtils.enginesForDomainPrefix and support UrlbarProviderTabToSearch sending multiple results. r=adw
Priority: P2 → P1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch

We can confirm the implementation of this enhancement. We verified it during our Nightly testing. The verification was done using Fx 83.0a1 (2020-10-13) on Windows 10 x64 and macOS 10.13.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: