Hit MOZ_CRASH(Didn't find a cached resource with that ID!) at gfx/wr/webrender/src/resource_cache.rs:257

#0 0x7ff521427424 in AnnotateMozCrashReason /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:42:19
#1 0x7ff521427424 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:331:3
#2 0x7ff521427424 in RustMozCrash /builds/worker/checkouts/gecko/mozglue/static/rust/wrappers.cpp:17:3
#3 0x7ff5214273d4 in mozglue_static::panic_hook::h718309d1c883b225 /builds/worker/checkouts/gecko/mozglue/static/rust/lib.rs:89:8
#4 0x7ff521426ccb in core::ops::function::Fn::call::hff608039b849de82 /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libcore/ops/function.rs:72:4
#5 0x7ff5227c4bd4 in std::panicking::rust_panic_with_hook::hb976084785e50594 /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/panicking.rs:474:16
#6 0x7ff5227c46ea in rust_begin_unwind /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/panicking.rs:378:4
#7 0x7ff5227ec7d0 in core::panicking::panic_fmt::h45f7d6868edb5678 /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libcore/panicking.rs:85:13
#8 0x7ff5227ec3b2 in core::option::expect_failed::h9a8bff6ff005b30d /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libcore/option.rs:1203:4
#9 0x7ff520fdd5ab in webrender::resource_cache::ResourceCache::get_image_info::hcca34ad9e54b4589 /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libcore/option.rs
#10 0x7ff520fdd5ab in webrender::resource_cache::ResourceCache::get_cached_image::h11cd83ca11fc4a47 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/resource_cache.rs:1064:25
#11 0x7ff520e8b9b8 in webrender::batch::resolve_image::h3cfa4760cce29da6 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/batch.rs:3044:44
#12 0x7ff520eaf1fd in webrender::composite::CompositeState::push_surface::hc982e058f5e162a9 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/composite.rs:593:33
#13 0x7ff520e86cb9 in webrender::batch::BatchBuilder::add_prim_to_batch::h572be306f97ca01b /builds/worker/checkouts/gecko/gfx/wr/webrender/src/batch.rs:1397:32
#14 0x7ff520f7383b in webrender::batch::BatchBuilder::add_pic_to_batch::h1e12a1f5ce727afa /builds/worker/checkouts/gecko/gfx/wr/webrender/src/batch.rs:766:16
#15 0x7ff520f7383b in _$LT$webrender..render_target..ColorRenderTarget$u20$as$u20$webrender..render_target..RenderTarget$GT$::build::h7b360eee6e1d2be4 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_target.rs:398:20
#16 0x7ff520ecba7d in webrender::frame_builder::build_render_pass::h10e4f0a7787ee44b /builds/worker/checkouts/gecko/gfx/wr/webrender/src/frame_builder.rs:725:12
#17 0x7ff520ecba7d in webrender::frame_builder::FrameBuilder::build::h5e7aeaff558d8ec0 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/frame_builder.rs:634:16
#18 0x7ff520f50feb in webrender::render_backend::Document::build_frame::he2a5f0ee30bb8b64 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:615:24
#19 0x7ff520f65176 in webrender::render_backend::RenderBackend::update_document::h37ecbb23c20bdb8b /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1520:40
#20 0x7ff520f6189b in webrender::render_backend::RenderBackend::prepare_transactions::h2533c62e75064bc1 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1357:31
#21 0x7ff520f6189b in webrender::render_backend::RenderBackend::process_api_msg::h55190795dc708db6 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1300:16
#22 0x7ff520f553b3 in webrender::render_backend::RenderBackend::run::h85617324568a2120 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:930:20
#23 0x7ff520d7b055 in webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::hb637c31b3788e1bd /builds/worker/checkouts/gecko/gfx/wr/webrender/src/renderer.rs:2629:12
#24 0x7ff520d7b055 in std::sys_common::backtrace::__rust_begin_short_backtrace::h3abec178bdac604f /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/sys_common/backtrace.rs:130:4
#25 0x7ff520d999c2 in std::thread::Builder::spawn_unchecked::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::h04655ad4debe6b2a /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/thread/mod.rs:475:16
#26 0x7ff520d999c2 in _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::hc3927586943dcb9c /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/panic.rs:318:8
#27 0x7ff520d999c2 in std::panicking::try::do_call::he90dd169dbd31238 /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libstd/panicking.rs:303:39
#28 0x7ff5227d5bf8 in __rust_maybe_catch_panic /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libpanic_abort/lib.rs:30:4

A Pernosco session is available here: https://pernos.co/debug/1-aPWlLQrYEe_UbxThiOxA/index.html

bp-8a085248-fc6d-47fd-8f3d-56bad0200624

c7766d0b4a121985a8b07e6721d66ccab57bbf76 sotaro — Bug 1617808 - Re-deliver PREFER_COMPOSITOR_SURFACE flag to WebRender r=gw

I take a look.

resource_cache.get_cached_image() was called, since external buffer uses resource_cache.

• https://searchfox.org/mozilla-central/rev/5a4aaccb28665807a6fd49cf48367d47fbb5a19a/gfx/wr/webrender/src/resource_cache.rs#1098

But at get_cached_image(), a cached image for the image did not exist.

:gw, what is a good way to address comment 8?

I can see the cause of this, I'll work on a fix this week.

(In reply to Glenn Watson [:gw] from comment #10)

I can see the cause of this, I'll work on a fix this week.

Thank you!

If an image is promoted to a compositor surface, but subsequently
clipped (by invalid clip rect) then we skip requesting the image
but still try to resolve the surface when building batches.

This patch reorders the primitive pass so that any decisions about
dropping a primitive from the visible list are made before the
prim dependencies (and compositor surfaces) are updated.

https://hg.mozilla.org/mozilla-central/rev/1cc79a886c3e

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

I don't believe we've seen any panics here on real world sites, so I don't think this needs an uplift.