Closed Bug 1647948 Opened 4 years ago Closed 4 years ago

Assertion failure: currentRatio == ComputeAspectRatio(&aImage, hasRequest, aFrame) (aspect-ratio got out of sync during paint? How?), at src/layout/generic/nsImageFrame.cpp:1769

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla79

Tracking Flags:

Tracking

Status

firefox-esr68

---

unaffected

firefox-esr78

---

wontfix

firefox77

---

wontfix

firefox78

---

wontfix

firefox79

---

fixed

People

(Reporter: tsmith, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

testcase.html 4 years ago Tyson Smith [:tsmith] (deleted), text/html		Details
testdata.ico 4 years ago Tyson Smith [:tsmith] (deleted), image/x-icon		Details
Bug 1647948. Relax assertion about image aspect ratio to consider that images can go into error state. r=emilio 4 years ago Timothy Nikkel (:tnikkel) (deleted), text/x-phabricator-request		Details

Tyson Smith [:tsmith]

Reporter

Description

•

4 years ago

Attached file testcase.html (deleted) — Details

Assertion failure: currentRatio == ComputeAspectRatio(&aImage, hasRequest, aFrame) (aspect-ratio got out of sync during paint? How?), at /builds/worker/checkouts/gecko/layout/generic/nsImageFrame.cpp:1769

#0 AnnotateMozCrashReason /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:42:19
#1 OldImageHasDifferentRatio /builds/worker/checkouts/gecko/layout/generic/nsImageFrame.cpp:1768:3
#2 nsDisplayImage::Paint(nsDisplayListBuilder*, gfxContext*) /builds/worker/checkouts/gecko/layout/generic/nsImageFrame.cpp:1779:7
#3 mozilla::FrameLayerBuilder::PaintItems(std::vector<mozilla::AssignedDisplayItem, std::allocator<mozilla::AssignedDisplayItem> >&, mozilla::gfx::IntRectTyped<mozilla::gfx::UnknownUnits> const&, gfxContext*, nsDisplayListBuilder*, nsPresContext*, mozilla::gfx::IntPointTyped<mozilla::gfx::UnknownUnits> const&, float, float) /builds/worker/checkouts/gecko/layout/painting/FrameLayerBuilder.cpp:7093:20
#4 mozilla::FrameLayerBuilder::DrawPaintedLayer(mozilla::layers::PaintedLayer*, gfxContext*, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::DrawRegionClip, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, void*) /builds/worker/checkouts/gecko/layout/painting/FrameLayerBuilder.cpp:7251:19
#5 mozilla::layers::ClientPaintedLayer::RenderLayerWithReadback(mozilla::layers::ReadbackProcessor*) /builds/worker/checkouts/gecko/gfx/layers/client/ClientPaintedLayer.cpp
#6 mozilla::layers::ClientContainerLayer::RenderLayer() /builds/worker/checkouts/gecko/gfx/layers/client/ClientContainerLayer.h:53:29
#7 mozilla::layers::ClientLayerManager::EndTransactionInternal(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::DrawRegionClip, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) /builds/worker/checkouts/gecko/gfx/layers/client/ClientLayerManager.cpp:342:13
#8 mozilla::layers::ClientLayerManager::EndTransaction(void (*)(mozilla::layers::PaintedLayer*, gfxContext*, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, mozilla::layers::DrawRegionClip, mozilla::gfx::IntRegionTyped<mozilla::gfx::UnknownUnits> const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) /builds/worker/checkouts/gecko/gfx/layers/client/ClientLayerManager.cpp:405:3
#9 nsDisplayList::PaintRoot(nsDisplayListBuilder*, gfxContext*, unsigned int) /builds/worker/checkouts/gecko/layout/painting/nsDisplayList.cpp:2484:19
#10 nsLayoutUtils::PaintFrame(gfxContext*, nsIFrame*, nsRegion const&, unsigned int, nsDisplayListBuilderMode, nsLayoutUtils::PaintFrameFlags) /builds/worker/checkouts/gecko/layout/base/nsLayoutUtils.cpp:4228:13
#11 mozilla::PresShell::Paint(nsView*, nsRegion const&, mozilla::PaintFlags) /builds/worker/checkouts/gecko/layout/base/PresShell.cpp:6378:5
#12 nsViewManager::ProcessPendingUpdatesPaint(nsIWidget*) /builds/worker/checkouts/gecko/view/nsViewManager.cpp:460:18
#13 nsViewManager::ProcessPendingUpdatesForView(nsView*, bool) /builds/worker/checkouts/gecko/view/nsViewManager.cpp:395:22
#14 nsViewManager::ProcessPendingUpdates() /builds/worker/checkouts/gecko/view/nsViewManager.cpp:1018:5
#15 nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:2191:11
#16 TickDriver /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:373:13
#17 mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:350:7
#18 mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:367:5
#19 RunRefreshDrivers /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:819:5
#20 mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:737:16
#21 mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:639:7
#22 mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::ParentProcessVsyncNotifier::Run() /builds/worker/checkouts/gecko/layout/base/nsRefreshDriver.cpp:538:20
#23 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1234:14
#24 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:501:10
#25 mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:87:21
#26 MessageLoop::RunInternal() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:315:10
#27 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:308:3
#28 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:290:3
#29 nsBaseAppShell::Run() /builds/worker/checkouts/gecko/widget/nsBaseAppShell.cpp:137:27
#30 XRE_RunAppShell() /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:913:20
#31 mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:237:9
#32 MessageLoop::RunInternal() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:315:10
#33 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:308:3
#34 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:290:3
#35 XRE_InitChildProcess(int, char**, XREChildData const*) /builds/worker/checkouts/gecko/toolkit/xre/nsEmbedFunctions.cpp:744:34
#36 content_process_main /builds/worker/checkouts/gecko/browser/app/../../ipc/contentproc/plugin-container.cpp:56:28
#37 main /builds/worker/checkouts/gecko/browser/app/nsBrowserApp.cpp:303:18

Flags: in-testsuite?

Tyson Smith [:tsmith]

Reporter

Comment 1

•

4 years ago

Attached image testdata.ico (deleted) — Details

Tyson Smith [:tsmith]

Reporter

Comment 2

•

4 years ago

A Pernosco session is available here: https://pernos.co/debug/aklHsc5dHW0JHUT9Qs4HUA/index.html

Timothy Nikkel (:tnikkel)

Assignee

Comment 3

•

4 years ago

Attached file Bug 1647948. Relax assertion about image aspect ratio to consider that images can go into error state. r=emilio (deleted) — Details

Phabricator Automation

Updated

•

4 years ago

Assignee: nobody → tnikkel

Status: NEW → ASSIGNED

Phabricator Automation

Updated

•

4 years ago

Attachment #9158814 - Attachment description: Bug 1647948. Relax assertion about image aspect ratio to consider that images can go into error state. r?emilio → Bug 1647948. Relax assertion about image aspect ratio to consider that images can go into error state. r=emilio

Pulsebot

Comment 4

•

4 years ago

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86de9115aa0b
Relax assertion about image aspect ratio to consider that images can go into error state. r=emilio

Dorel Luca [:dluca]

Comment 5

•

4 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/86de9115aa0b

Status: ASSIGNED → RESOLVED

Closed: 4 years ago

status-firefox79: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla79

Ryan VanderMeulen [:RyanVM]

Updated

•

4 years ago

status-firefox77: --- → wontfix

status-firefox78: --- → wontfix

status-firefox-esr68: --- → unaffected

status-firefox-esr78: --- → wontfix

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Assertion failure: currentRatio == ComputeAspectRatio(&aImage, hasRequest, aFrame) (aspect-ratio got out of sync during paint? How?), at src/layout/generic/nsImageFrame.cpp:1769

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect)

Tracking

()

People

(Reporter: tsmith, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Crash Data

Security

(public)

User Story

Attachments

(3 files)

Description

Comment 1

Comment 2

Comment 3

Updated

Updated

Comment 4

Comment 5

Updated

Attachment

General

Description

File Name

Content Type