Closed Bug 1648107 Opened 4 years ago Closed 4 years ago

[Fission] PiP offered but doesn't work

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

defect

Tracking

()

RESOLVED FIXED
82 Branch
Fission Milestone M6b
Tracking Status
firefox78 --- unaffected
firefox79 --- unaffected
firefox82 --- fixed

People

(Reporter: overholt, Assigned: mconley)

References

Details

Attachments

(1 file)

STR

  1. go to https://www.theverge.com/ and click on a video play button right from their home page (not an article)
  2. see the PiP affordance and click it

Expected: PiP video
Actual: nothing

I'm on the 2020-06-22 Nightly on Windows 10

Can't reproduce on beta or nightly on macOS.

Can you check a clean profile? Is this happening only with fission enabled, maybe? What OS are you seeing this on? Any errors in the browser console when PiP fails to open?

Flags: needinfo?(overholt)

Sorry, I verified it works in a non-Fission window. Nothing in the console, FWIW.

Fission Milestone: --- → ?
Flags: needinfo?(overholt)
Summary: PiP offered but doesn't work → [Fission] PiP offered but doesn't work
Blocks: 1575868

Tracking for Fission M6b Nightly.

Fission Milestone: ? → M6b

The severity is N/A here as Fission is still off by default (even though more people are turning it on). As we get closer to enabling Fission by default on Nightly, we should adjust the Severity field.

Severity: -- → N/A
Priority: -- → P3

Can confirm the issue in OP with most recent nightly build and fission.autostart = true.
To add to the discussion, I've opened a similar issue on webcompat here https://github.com/webcompat/web-bugs/issues/54274 but it was closed and the bugherder never replied about re-testing with fission enabled.

(In reply to Mike Conley (:mconley) (:⚙️) from comment #5)

The severity is N/A here as Fission is still off by default (even though more people are turning it on). As we get closer to enabling Fission by default on Nightly, we should adjust the Severity field.

This should be a S3 severity instead of N/A since the work around for the bug is leaving the feature disabled. As more people are exposed to the feature, then up-rating the severity would be, as you said, the next right thing.

Severity: N/A → S3

Mike, this is a blocker for Fission Nightly. Is it blocked on anything from DOM?

Flags: needinfo?(mconley)

No, I think we have everything we need from DOM. I'll see if we can get this fixed next week.

Flags: needinfo?(mconley)
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c499848501df Make sure PiP player window browser uses the right content process when Fission is enabled. r=NeilDeakin
Blocks: 1596790
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: