Closed
Bug 1648341
Opened 4 years ago
Closed 4 years ago
ARIA role "separator" should only expose values if not read-only
Categories
(Core :: Disability Access APIs, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: MarcoZ, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Right now, it always exposes a value of 50% if it is read-only.
- Open data:text/html,<div role="separator"></div>
- NVDA will report it as a separator with 50%.
|
Assignee | |
Comment 1•4 years ago
|
||
Accessible::Value checks roleMapEntry->valueRule != eNoValue, but that ignores focusability. I think it can instead just use HasNumericValue(), which checks both native and ARIA (and honous focusability for ARIA), but need to make sure that doesn't break something I'm missing.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Previously, this returned a value if the ARIA value rule was not eNoValue, which covered eHasValueMinMaxIfFocusable.
However, eHasValueMinMaxIfFocusable needs the focusable state to be checked.
Rather than checking the value rule directly, just use HasNumericValue(), which already knows how to handle this.
|
||
Updated•4 years ago
|
Assignee: nobody → jteh
Status: NEW → ASSIGNED
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78e46b3dcf0f
Handle eHasValueMinMaxIfFocusable correctly in Accessible::Value. r=MarcoZ
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•