Closed Bug 1648378 Opened 4 years ago Closed 4 years ago

Remove virtual memory from about:processes

Categories

(Core :: DOM: Content Processes, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: Yoric, Assigned: soniasingla, Mentored, NeedInfo)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js][lang=html])

Attachments

(4 files)

So, we can either remove it entirely or hide it behind a pref.
Any preference, nika, kmag?

Flags: needinfo?(nika)
Flags: needinfo?(kmaglione+bmo)

I don't really see much of a reason to keep it around, so I'd be fine with just completely removing it.

Flags: needinfo?(nika)
Keywords: good-first-bug
Whiteboard: [lang=js][lang=html]
Mentor: dteller

Marking this bug as mentored.

The objective of this bug is to patch aboutProcesses.js, aboutProcesses.html, aboutProcesses.css and aboutProcesses.ftl to get rid of the column called "Virtual memory" (column-memory-virtual).

Flags: needinfo?(kmaglione+bmo)
Attached patch Correction to aboutProcesses.js (deleted) — Splinter Review
Attachment #9162818 - Flags: review+
Attachment #9162818 - Flags: feedback+
Attached patch Patch to aboutProcesses.html (deleted) — Splinter Review
Attachment #9162826 - Flags: review+
Attachment #9162826 - Flags: feedback+
Attached patch Patch to aboutProcesses.ftl (deleted) — Splinter Review
Attachment #9162829 - Flags: review+
Attachment #9162829 - Flags: feedback+

Hey, Daniel Zhang, thanks for the patches!

Unfortunately, we have stopped using splinter a few years ago. Any chance you could use phabricator instead? I realize that the documentation of phabricator can be arid, so don't hesitate to ask questions on #introduction!

Flags: needinfo?(nydanny2014)
Fission Milestone: --- → M6a

Note that you'll need to use moz-phab submit to send the patches, instead of sending the modified files.

Fission Milestone: M6a → M6b

Note: We have deadline issues here, so if this bug isn't completed next week, I'll pick it up.

Flags: needinfo?(dteller)
Assignee: nobody → soniasingla.1812
Status: NEW → ASSIGNED
Pushed by dteller@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47bf6da3e008 Removed Virtual Memory from about:processes r=Yoric,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: needinfo?(dteller)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: