Closed
Bug 1648680
Opened 4 years ago
Closed 4 years ago
Implicit declaration of WSAIoctl in w95sock.c
Categories
(NSPR :: NSPR, defect)
NSPR
NSPR
Tracking
(firefox80 fixed)
RESOLVED
FIXED
4.27
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Comment 3•4 years ago
|
||
The severity field is not set for this bug.
:KaiE, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(kaie)
|
||
Updated•4 years ago
|
Severity: -- → S3
Flags: needinfo?(kaie)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/128b0d6ba0b5
Do not build w95sock.c as part of a unified compilation unit. r=dmajor
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
|
||
Comment 6•4 years ago
|
||
|
|
||
Comment 7•4 years ago
|
||
IIUC you worked around the header issue by using a change to the firefox build system.
Do you want the change to NSPR to uplift for FF 80, or can it wait longer?
Flags: needinfo?(mh+mozilla)
|
|
Assignee | |
Comment 8•4 years ago
|
||
The issue is not worked around in Firefox. The Firefox change is to preemptively fix the fact that the NSPR change breaks unified builds because both winsock2.h and winsock.h would be included, which breaks.
It would be good to have asap in Firefox to be able to land bug 822978.
Flags: needinfo?(mh+mozilla)
|
|
||
Updated•4 years ago
|
Target Milestone: --- → 4.27
You need to log in
before you can comment on or make changes to this bug.
Description
•