Closed Bug 1648731 Opened 4 years ago Closed 3 years ago

Port the ASan reporter add-on

Categories

(Thunderbird :: Build Config, enhancement, P3)

enhancement

Tracking

(thunderbird_esr91 unaffected, thunderbird100 unaffected)

RESOLVED FIXED
101 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird100 --- unaffected

People

(Reporter: tdulcet, Assigned: rjl)

References

Details

Attachments

(4 files)

Port the ASan reporter add-on from Firefox, to make fuzzing Thunderbird and reporting security vulnerabilities easier. This was added to Firefox in Bug 1386304. Also see:

This was first requested in Bug 1641581.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Depends on: 1682004

The reporter code is built into Firefox now. Bug 1487173. The biggest obstacle to including it is probably going to be the "crashproxy" piece which is a server at https://anf1.fuzzing.mozilla.org/crashproxy/submit/.

Blocks: 1716977

This bug is actionable now!

Per Chris Holler, Thunderbird can submit results to the Firefox crashproxy. Due to limitations in the infrastructure, Thunderbird devs won't have direct access to the results, but the necessary information will be filed in Bugzilla for issues that can be fixed.

The current ASan builds need to be converted to "shippable" builds, the reporter code needs enabling, and a Balrog channel(?) set up (in bug 1716977).

Does it make sense to move AsanReporter.jsm to /toolkit/modules to avoid copying it to comm/mail/modules?

Flags: needinfo?(choller)

(In reply to Rob Lemley [:rjl] from comment #3)

Does it make sense to move AsanReporter.jsm to /toolkit/modules to avoid copying it to comm/mail/modules?

If you can make the same module work for Firefox and TB, then I think that's a good way to move forward, yes :)

Flags: needinfo?(choller)
Depends on: 1764092
Assignee: nobody → rob
Status: NEW → ASSIGNED

Depends on D143515

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/97323aeeed59
Initialize AsanReporter when enabled. r=mkmelin
https://hg.mozilla.org/comm-central/rev/6a84da06fc27
Thunderbird AsanReporter build config. r=#thunderbird-reviewers,mkmelin

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Pushed by thunderbird@calypsoblue.org: https://hg.mozilla.org/comm-central/rev/46144813d847 Backed out changeset 6a84da06fc27 for build failures. rs=backout https://hg.mozilla.org/comm-central/rev/c6a1217c774f Thunderbird AsanReporter build config. r=#thunderbird-reviewers,mkmelin
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/d6b0477f76c2
Follow-up: Set correct project when building asan-reporter for Win. r=aleca

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9f307f88fb90
Follow-up: Do not upload symbols for asan-reporter builds. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED

Backout: https://hg.mozilla.org/comm-central/rev/011c5679fadd988db71a9ca043dbe34ba23cb006

https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=Iyh1XNrISk2v8PvXcRJHvg.0&revision=ed5dc30ac9653aec86ae735bbec516a2d7e431a9

Exception: Shippable job build-linux64-asan-reporter-shippable/opt should have enable-full-crashsymbols attribute set to true to enable symbol upload to crash-stats

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by alessandro@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/27ec2ba4d087
Follow-up: Do not upload symbols for asan-reporter builds. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: