Closed
Bug 1649306
Opened 4 years ago
Closed 1 year ago
null pointer passed as argument 1, which is declared to never be null in dom/crypto/CryptoBuffer.cpp:131
Categories
(Core :: DOM: Web Crypto, defect, P3)
Core
DOM: Web Crypto
Tracking
()
RESOLVED
FIXED
118 Branch
People
(Reporter: tsmith, Assigned: keeler)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This can be triggered via mochitests. To enable this check add the following to your mozconfig:
ac_add_options --enable-undefined-sanitizer="nonnull-attribute"
INFO - TEST-START | dom/crypto/test/test_WebCrypto_HKDF.html
src/dom/crypto/CryptoBuffer.cpp:131:10: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/include/string.h:47:28: note: nonnull attribute specified here
#0 0x7f3f49ded81e in mozilla::dom::CryptoBuffer::ToSECItem(PLArenaPool*, SECItemStr*) const src/dom/crypto/CryptoBuffer.cpp:131:3
#1 0x7f3f49e1f612 in mozilla::dom::DeriveHkdfBitsTask::DoCrypto() src/dom/crypto/WebCryptoTask.cpp:2441:5
#2 0x7f3f49dfebb3 in CalculateResult src/dom/crypto/WebCryptoTask.cpp:394:10
#3 0x7f3f49dfebb3 in mozilla::dom::WebCryptoTask::Run() src/dom/crypto/WebCryptoTask.cpp:355:11
#4 0x7f3f44a14169 in nsThreadPool::Run() src/xpcom/threads/nsThreadPool.cpp:299:14
#5 0x7f3f44a05a83 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1234:14
#6 0x7f3f44a1000c in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:504:10
#7 0x7f3f45b180e9 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:302:20
#8 0x7f3f45a34ed7 in RunInternal src/ipc/chromium/src/base/message_loop.cc:316:10
#9 0x7f3f45a34ed7 in RunHandler src/ipc/chromium/src/base/message_loop.cc:309:3
#10 0x7f3f45a34ed7 in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:291:3
#11 0x7f3f449fe9ba in nsThread::ThreadFunc(void*) src/xpcom/threads/nsThread.cpp:447:10
#12 0x7f3f62186fa7 in _pt_root src/nsprpub/pr/src/pthreads/ptthread.c:201:5
#13 0x7f3f65e446da in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76da)
#14 0x7f3f64e2288e in clone /build/glibc-OTsEL5/glibc-2.27/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95
Comment 1•4 years ago
|
||
The severity field is not set for this bug.
:jcj, could you have a look please?
For more information, please visit auto_nag documentation.
Flags: needinfo?(jjones)
Updated•4 years ago
|
Severity: -- → S2
Flags: needinfo?(jjones)
Priority: -- → P3
Comment 2•1 year ago
|
||
Dana, this is a S2 which hasn't had any activity in a very long time. Can you please re-evaluate its severity and find an assignee for it, if it still is a valid actionable S2?
Flags: needinfo?(dkeeler)
Assignee | ||
Comment 3•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(dkeeler)
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2506aaa10bd
webcrypto: avoid passing null to memcpy (even when length is 0) r=jschanck
Comment 5•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Updated•1 year ago
|
status-firefox116:
--- → wontfix
status-firefox117:
--- → wontfix
status-firefox-esr102:
--- → wontfix
status-firefox-esr115:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•