JSONFile.jsm imports OS.File during startup
Categories
(Toolkit Graveyard :: OS.File, task)
Tracking
(firefox92 fixed)
Tracking | Status | |
---|---|---|
firefox92 | --- | fixed |
People
(Reporter: barret, Assigned: emmamalysz)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
According to this startup profile, JSONFile.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.
Stack:
(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
AsyncFunctionNext [self-hosted:688:26]
asyncEmitManifestEntry [resource://gre/modules/ExtensionCommon.jsm:1542:30]
0xff4eaa5dbc7 []
js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
onManifestEntry [chrome://browser/content/parent/ext-commands.js:20:23]
loadCommands [resource://gre/modules/ExtensionShortcuts.jsm:165:14]
loadCommands/this.commands< [resource://gre/modules/ExtensionShortcuts.jsm:171:27]
loadCommandsFromStorage [resource://gre/modules/ExtensionShortcuts.jsm:256:31]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:319:12]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:98:19]
> load [resource://gre/modules/JSONFile.jsm:195:12]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
Comment 4•4 years ago
|
||
Backed out for causing xpcshell and marionette failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a5e436040f26431caabe563e23672c7a605c1f5e
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=YYCB-R-rQPSto2pmWMXkGg.0&revision=db75491e5d2eb754452146cffe297f0d77033052&searchStr=marionette
Failure log: https://treeherder.mozilla.org/logviewer?job_id=327706255&repo=autoland&lineNumber=62139
https://treeherder.mozilla.org/logviewer?job_id=327704899&repo=autoland&lineNumber=3748
https://treeherder.mozilla.org/logviewer?job_id=327706972&repo=autoland&lineNumber=2336
Comment 5•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 6•4 years ago
|
||
This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?
Comment 7•4 years ago
|
||
(In reply to :Gijs (he/him) from comment #6)
This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?
D'oh, cleared the wrong needinfo.
Comment 9•4 years ago
|
||
Backed out for causing failure on test_update_theme.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/fe4b842cb23c9c1fce56e5457b3c16717eeff091
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334175448&repo=autoland&lineNumber=2559
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
Backed out for causing Xpcshell failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/12e64cff7f81280003506ee280ea38a03e9c5745
Failure log: https://treeherder.mozilla.org/logviewer?job_id=337472307&repo=autoland&lineNumber=2440
https://treeherder.mozilla.org/logviewer?job_id=337467812&repo=autoland&lineNumber=3058
Comment 12•4 years ago
|
||
Comment 13•4 years ago
|
||
Backed out changeset 4f76a69e26f9 (bug 1649604) for XPCshell failures in xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_strictcompatibility.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=338203184&repo=autoland&lineNumber=3275
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4f76a69e26f93dc93a2cceca33e969b4eb6f77a5
Backout:
https://hg.mozilla.org/integration/autoland/rev/28e04a08d2e42d3579b28b36becda67d945d6abe
Updated•3 years ago
|
Updated•3 years ago
|
Comment 14•3 years ago
|
||
Comment 15•3 years ago
|
||
bugherder |
Updated•2 years ago
|
Description
•