Closed Bug 1649604 Opened 4 years ago Closed 3 years ago

JSONFile.jsm imports OS.File during startup

Categories

(Toolkit Graveyard :: OS.File, task)

Tracking

(firefox92 fixed)

RESOLVED FIXED
92 Branch
Tracking Status
firefox92 --- fixed

People

(Reporter: barret, Assigned: emmamalysz)

References

Details

Attachments

(1 file, 1 obsolete file)

According to this startup profile, JSONFile.jsm runs during startup and imports osfile.jsm. We should migrate this to the new IOUtils replacement for osfile.jsm when possible.

Stack:

(root) []
XREMain::XRE_main []
XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [libxul.so]
XREMain::XRE_mainRun() [libxul.so]
nsAppStartup::Run() [libxul.so]
nsBaseAppShell::Run() [libxul.so]
MessageLoop::Run() [libxul.so]
mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [libxul.so]
nsThread::ProcessNextEvent(bool, bool*) [libxul.so]
mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) [libxul.so]
promise callback []
mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) [libxul.so]
mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) [libxul.so]
JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
PromiseReactionJob(JSContext*, unsigned int, JS::Value*) [libxul.so]
AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) [libxul.so]
js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [libxul.so]
js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) [libxul.so]
js::RunScript []
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
AsyncFunctionNext [self-hosted:688:26]
asyncEmitManifestEntry [resource://gre/modules/ExtensionCommon.jsm:1542:30]
0xff4eaa5dbc7 []
js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [libxul.so]
js::RunScript []
onManifestEntry [chrome://browser/content/parent/ext-commands.js:20:23]
loadCommands [resource://gre/modules/ExtensionShortcuts.jsm:165:14]
loadCommands/this.commands< [resource://gre/modules/ExtensionShortcuts.jsm:171:27]
loadCommandsFromStorage [resource://gre/modules/ExtensionShortcuts.jsm:256:31]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:319:12]
initialize [resource://gre/modules/ExtensionSettingsStore.jsm:98:19]
> load [resource://gre/modules/JSONFile.jsm:195:12]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
Interpret(JSContext*, js::RunState&) [libxul.so]
js::NativeGetExistingProperty(JSContext*, JS::Handle<JSObject*>, JS::Handle<js::NativeObject*>, JS::Handle<js::Shape*>, JS::MutableHandle<JS::Value>) [libxul.so]
js::CallGetter(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::MutableHandle<JS::Value>) [libxul.so]
js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) [libxul.so]
mozilla::dom::module_getter::ModuleGetter(JSContext*, unsigned int, JS::Value*) [libxul.so]
mozJSComponentLoader::Import(JSContext*, nsTSubstring<char> const&, JS::MutableHandle<JSObject*>, JS::MutableHandle<JSObject*>, bool) [libxul.so]
profiler_get_backtrace() [libxul.so]
Registers::SyncPopulate() [libxul.so]
Depends on: 1673038
Depends on: 1671035
No longer depends on: 1673038
Depends on: 1679704
Assignee: nobody → emalysz
Attached file Bug 1649604, remove OS.File usage from JSONFile.jsm (obsolete) (deleted) —
Attachment #9196512 - Attachment is obsolete: true
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/db75491e5d2e remove OS.File usage from JSONFile.jsm r=Gijs
Depends on: 1672431
Flags: needinfo?(emalysz)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emalysz, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(emalysz)

This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?

Flags: needinfo?(emalysz)

(In reply to :Gijs (he/him) from comment #6)

This hadn't landed because of bug 1672431, which landed and stuck 4 hours ago, so we should be able to land this now, I think, Emma?

D'oh, cleared the wrong needinfo.

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(emalysz)
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/065644a4b755 remove OS.File usage from JSONFile.jsm r=Gijs
Depends on: 1702116
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bac3906ff3ff remove OS.File usage from JSONFile.jsm r=Gijs
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f76a69e26f9 remove OS.File usage from JSONFile.jsm r=Gijs
Blocks: 1522925
Depends on: 1712642
Flags: needinfo?(emalysz)
Attachment #9197494 - Attachment description: Bug 1649604, remove OS.File usage from JSONFile.jsm → WIP: Bug 1649604, remove OS.File usage from JSONFile.jsm
Attachment #9197494 - Attachment description: WIP: Bug 1649604, remove OS.File usage from JSONFile.jsm → Bug 1649604, remove OS.File usage from JSONFile.jsm
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/acba61a1c652 remove OS.File usage from JSONFile.jsm r=Gijs,robwu
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
Regressions: 1723812
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: