Closed
Bug 1649740
Opened 4 years ago
Closed 4 years ago
Missing space between blocklist message and bugs in about:support
Categories
(Toolkit :: General, defect, P1)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: flod, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
immagine.png
Issue reported by one of our localizers.
Looking at the code, it looks like the previous string had an hard-coded "; " added at the end.
https://hg.mozilla.org/mozilla-central/rev/3f16eb2a8603#l3.572
Right now, there's no space between Blocklisted due to known issues and the bug links.
|
Assignee | |
Updated•4 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
|
Reporter | |
Comment 1•4 years ago
|
||
I've been thinking a bit about this: I'm not a huge fan of having a trailing whitespace, and just adding some padding to the link wouldn't help (the first part is disconnected from the second).
Can we use one string instead, since the bug is always only one?
# Variables
# $bugNumber (string) - Bug number on Bugzilla
support-blocklisted-bug = Blocklisted due to known issues: <a data-l10n-name="bug-link">bug { $bugNumber }</a>
| Comment hidden (off-topic) |
|
|
Assignee | |
Comment 3•4 years ago
|
||
comment #1 seems like a great solution.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P1
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2053ed112b61
fix blocklist string for graphics features in about:support, r=flod,fluent-reviewers
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
|
||
Comment 7•4 years ago
|
||
Thank you, the error is fixed in Fx 80 Nightly now. The new string is still in English but I'm sure it will land on Pontoon soon.
|
||
Updated•4 years ago
|
QA Whiteboard: [qa-80b-p2]
|
||
Updated•3 years ago
|
Keywords: regression
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•