Closed Bug 1649757 Opened 4 years ago Closed 4 years ago

stop uploading artifacts (the shell, jsapi-tests) for SM that don't have tests

Categories

(Core :: JavaScript Engine, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

These are showing up as large, relatively expensive artifacts in some cases (nonunified builds particularly), and we should stop doing that. I have a patch that disables them for nonunified and plain builds, but perhaps there are more.

The artifacts (js, jsapi-tests) generated by these builds are rather
large, and we don't need them for anything.

Assignee: nobody → nfroyd
Status: NEW → ASSIGNED

From the phabricator revision:

I think the next version of the patch will probably include this under the "$upload" = "1" check, assuming that fuzzing builds are always going to want uploads. We don't need to upload the symbolizer for each and every build nowadays.

That was an explicit request from gkw to include this. Something about the way their system worked made it much easier if I did this. It is possible that it no longer matters; I'll needinfo decoder.

:decoder, are the fuzzing build artifacts, and the matching llvm-symbolizer binary in particular, useful to you? And if so, would a shorter expiration period make them less useful? Thanks.

Flags: needinfo?(choller)

Fuzzing build artifacts are important for bisection and a shorter expiration period will harm bisection results.

As for llvm-symbolizer, it should be included in sanitizer builds only, but there it is required. Note that this is not just fuzzing builds, since some JS shell fuzzing runs on non-fuzzing builds.

I also checked the attached patch and I believe none of the 3 builds mentioned in there are used in fuzzing.

Flags: needinfo?(choller)
Severity: -- → N/A
Type: task → enhancement
Priority: -- → P1
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5de1f21de997 don't upload artifacts for various SM builds; r=sfink
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: