stop uploading artifacts (the shell, jsapi-tests) for SM that don't have tests
Categories
(Core :: JavaScript Engine, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
These are showing up as large, relatively expensive artifacts in some cases (nonunified builds particularly), and we should stop doing that. I have a patch that disables them for nonunified and plain builds, but perhaps there are more.
Assignee | ||
Comment 1•4 years ago
|
||
The artifacts (js
, jsapi-tests
) generated by these builds are rather
large, and we don't need them for anything.
Updated•4 years ago
|
Comment 2•4 years ago
|
||
From the phabricator revision:
I think the next version of the patch will probably include this under the "$upload" = "1" check, assuming that fuzzing builds are always going to want uploads. We don't need to upload the symbolizer for each and every build nowadays.
That was an explicit request from gkw to include this. Something about the way their system worked made it much easier if I did this. It is possible that it no longer matters; I'll needinfo decoder.
:decoder, are the fuzzing build artifacts, and the matching llvm-symbolizer
binary in particular, useful to you? And if so, would a shorter expiration period make them less useful? Thanks.
Comment 3•4 years ago
|
||
Fuzzing build artifacts are important for bisection and a shorter expiration period will harm bisection results.
As for llvm-symbolizer
, it should be included in sanitizer builds only, but there it is required. Note that this is not just fuzzing builds, since some JS shell fuzzing runs on non-fuzzing builds.
I also checked the attached patch and I believe none of the 3 builds mentioned in there are used in fuzzing.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
bugherder |
Description
•