Refactor minimum Rust version for bootstrap and configure into a common place
Categories
(Firefox Build System :: General, enhancement, P3)
Tracking
(firefox80 fixed)
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: froydnj, Assigned: rstewart)
Details
(Keywords: in-triage)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
That way we won't have to worry about bug 1649039 popping up again.
|
||
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
Reporter | |
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
Can we just reduce code duplication by putting the minimum Rust version in some common place? configure and bootstrap can both import it. Seems just as foolproof and easier to do than setting up a separate lint.
|
|
Reporter | |
Comment 3•4 years ago
|
||
(In reply to Ricky Stewart from comment #2)
Can we just reduce code duplication by putting the minimum Rust version in some common place?
configureandbootstrapcan both import it. Seems just as foolproof and easier to do than setting up a separate lint.
I think if we can do that and either a) still have the single-file bootstrap.py script work or b) remove the single-file bootstrap.py script first, that would be preferable to a lint. We do manage to make something like this work for Android, so it ought to work for Rust as well.
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
Lint seems overkill.
|
|
Assignee | |
Comment 5•4 years ago
|
||
The lack of duplication should prevent bugs like bug 1649039 popping up again.
|
|
Assignee | |
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
Description
•