Closed Bug 1650193 Opened 4 years ago Closed 4 years ago

Make test_innerWidthHeight_script pass with apz.allow_zooming=true

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Spinoff from https://bugzilla.mozilla.org/show_bug.cgi?id=1621740#c14

This test loads a page that is wider than it is tall, with a meta-viewport that specifies a square viewport. This necessarily will expand the layout viewport to be square as well, which then introduces a vertical scrollbar. On Linux the vertical scrollbar is not an overlay scrollbar, and so takes up space that reduces the document.documentElement.clientWidth property tested in the test. This causes the test to fail.

It seems like the test is basically ignoring layout space taken up by scrollbars, so it makes sense to always run this test with overlay scrollbars.

This allows it to pass when run on desktop with apz.allow_zooming=true.

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fded30d6b9e0 Make test_innerWidthHeight_script use overlay scrollbars. r=tnikkel
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: