Closed Bug 1650224 Opened 4 years ago Closed 4 years ago

Backfill action to support manifest scheduled tasks (remove new_backfill action)

Categories

(Firefox Build System :: Task Configuration, enhancement, P1)

enhancement

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: armenzg, Assigned: armenzg)

References

Details

(Whiteboard: [manifest-scheduling])

Attachments

(4 files)

Bug 1639873 allows backfilling tasks that use test manifests. This can be achieved via a Custom action from the Treeherder UI.

We can now replace the current backfill with the new one.

The backfill action will support both tasks with manifest based scheduling and without.

This adds the support for backfilling of manifest scheduled tasks while
preserving the existing features (e.g. schedule a specific test path).

We remove the temporary new-backfill action.

Summary: Merge new and original backfill → Backfill action to support manifest scheduled tasks (remove new_backfill action)

This optional mode to specify a test path when backfilling has been broken for a while
and is not being used to make it worth fixing. It is a mode
originally designed to be used with the test-verify tasks.

Attached patch patch (deleted) — Splinter Review
Comment on attachment 9162168 [details] [diff] [review] patch I belive this diff helps seeing what changes I did to the new_backfill you already reviewed. This helps reviewing https://phabricator.services.mozilla.com/D82599
Attachment #9162168 - Flags: review?(mozilla)

Sheriffs, when this code lands on autoland (which I will land early on my day) we will need to pay close attention to the backfill action from that point on.

I've tested this with some hacks on Try, however, I will need your close attention and check quickly with me the day we land this so we can back it out quickly if necessary.

This change affects the backfill request from Treeherder's UI.

The NI is only to ensure you see this comment. I will check on Riot before landing.

Flags: needinfo?(sheriffs)
Flags: needinfo?(aryx.bugmail)
Whiteboard: [manifest-scheduling]

The first push contains the code in this bug.
The second push is the state of mozilla-central, thus, backfilling with the new code can schedule over pushes with the old code (This makes sense since the backfill-task action is landed since last week).

Pushed by armenzg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c96d73d17b9a Drop support of testPath from backfill action r=tomprince https://hg.mozilla.org/integration/autoland/rev/d048d01665a5 Support backfilling of manifest scheduled tasks r=tomprince

So far it seems working.

I'm seeing Bk and backfill-task actions.

I see bc6 and bc6-revision-bk tasks.

This seems to work so far.

If filtering tasks gets annoying feel free to ask the team to promote this change as I'm away tomorrow:
https://github.com/mozilla/treeherder/commit/50005b1b13d1fa3793c61d94a75d2970090d46b3

Flags: needinfo?(sheriffs)
Flags: needinfo?(aryx.bugmail)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Attachment #9162168 - Flags: review?(mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: