Introduce a performance marker capturing number/size of requests added
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: Honza, Unassigned)
References
(Blocks 1 open bug)
Details
This is inspired by Julian's work in bug 1634466
Let's introduce a Performance middle-ware in the Network panel responsible for adding profiler markers (using ChromeUtils.addProfilerMarker
)
file: performance-marker.js
function: performanceMarkerMiddleware()
The first marker ID could be: NetmonitorAddRequest
. The ID should use actor ID as postfix, so we can make a difference between markers coming from the content toolbox and Browser Toolbox
The marker should be responsible for calculating and storing:
- time needed to update the requests reducer
- count of requests in the reducer
- size of the added request
- size of the requests in the reducer
Let's also share code base with the Console if needed.
Honza
Reporter | ||
Comment 1•4 years ago
|
||
Harald, WDYT?
Any other data we could calculate/track...?
Honza
Comment 2•4 years ago
|
||
Depends on if every incoming update causes a render. This seems a lot of meta data for one marker. If we stay in line with Console, we would just count the number of requests – correct?
Reporter | ||
Comment 3•4 years ago
|
||
(In reply to :Harald Kirschner :digitarald from comment #2)
Depends on if every incoming update causes a render. This seems a lot of meta data for one marker. If we stay in line with Console, we would just count the number of requests – correct?
The console is just counting number of messages, correct.
(counting also size could indicate whether requesting big data have an impact or not)
Honza
Description
•