Closed Bug 1650406 Opened 4 years ago Closed 4 years ago

upload-symbols tasks showing up and causing builds with |mach try auto| again

Categories

(Firefox Build System :: Task Configuration, task, P1)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task

Tracking

(firefox80 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r?Callek
(deleted), text/x-phabricator-request
Details
Bug 1650406 - [ci] Ensure 'build-win64-aarch64-shippable-no-eme/opt' runs everywhere, r?#firefox-build-system-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1650406 - [ci] Add more tests for tasks that shouldn't be running on |mach try auto| pushes, r?Callek
(deleted), text/x-phabricator-request
Details
Bug 1650406 - [ci] Use 'if-dependencies' with upload-symbols tasks
(deleted), text/x-phabricator-request
Details
Bug 1650406 - [ci] Ensure 'test-verify' tasks use the 'test' strategy with |mach try auto|, r?marco
(deleted), text/x-phabricator-request
Details
Bug 1650406 - [taskgraph] Never run 'upload-symbols' tasks with |mach try auto|, r?marco
(deleted), text/x-phabricator-request
Details

Something changed and now all |mach try auto| pushes seem to be scheduling the sym tasks again, and they even seem to be causing opt builds to run.

Assignee: nobody → ahal
Status: NEW → ASSIGNED
Priority: P2 → P1

This was likely caused by us switching to opt on try instead of shippable:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/upload_symbols.py#74

Attachment #9161941 - Attachment description: Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r?Callek → Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run as a dependency, r?Callek
Attachment #9161941 - Attachment description: Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run as a dependency, r?Callek → Bug 1650406 - [ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r?Callek

Hey Nathan and Mike, picking on your two since you commented on the revision (sorry).

But I really need a resolution on this. The one build you both identified should definitely be running has been fixed by:
https://phabricator.services.mozilla.com/D83676

Is that everything?

Flags: needinfo?(nfroyd)
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(nfroyd)

Thanks Nathan!

Flags: needinfo?(mh+mozilla)
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0df4c7fd0d55 [ci] Ensure 'build-win64-aarch64-shippable-no-eme/opt' runs everywhere, r=nalexander https://hg.mozilla.org/integration/autoland/rev/034864174a6f [ci] Ensure 'upload-symbols' tasks don't cause builds to run with |mach try auto|, r=Callek,froydnj

https://hg.mozilla.org/mozilla-central/rev/0df4c7fd0d55
https://hg.mozilla.org/mozilla-central/rev/034864174a6f

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Hm, this seems to have regressed again. Last time this landed the integration tests didn't exist, this time I'll make sure I include a check to ensure it doesn't happen again.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: leave-open
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98bf32dc78b0 [ci] Add more tests for tasks that shouldn't be running on |mach try auto| pushes, r=Callek
Depends on: 1659187

Depends on D87776

Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9cf6e6790048 [ci] Use 'if-dependencies' with upload-symbols tasks r=bhearsum
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/910e5a2c9a20 [ci] Ensure 'test-verify' tasks use the 'test' strategy with |mach try auto|, r=marco https://hg.mozilla.org/integration/autoland/rev/df54683ff216 [taskgraph] Never run 'upload-symbols' tasks with |mach try auto|, r=marco
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: