Enable GPU switching on Mac
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: wr-planning)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
This still has texture conversion happening.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
It looks like the conversion is caused by us using a different external format when we do the TexImage3D vs the TexSubImage3D.
i.e. We do TexImage3D(GL_RGBA8, GL_RGBA, GL_UNSIGNED_BYTE)
which we get from https://searchfox.org/mozilla-central/rev/e11d919cdc8a909354eb2c3e19904d9229c55d88/gfx/wr/webrender/src/device/gl.rs#3696
called from https://searchfox.org/mozilla-central/rev/e11d919cdc8a909354eb2c3e19904d9229c55d88/gfx/wr/webrender/src/device/gl.rs#2191 which is set to ImageFormat::RGBA8 https://searchfox.org/mozilla-central/source/gfx/wr/webrender/src/texture_cache.rs#1076
from https://searchfox.org/mozilla-central/rev/e11d919cdc8a909354eb2c3e19904d9229c55d88/gfx/wr/webrender/src/device/gl.rs#1428
|
|
Assignee | |
Comment 4•4 years ago
|
||
My latest phabricator update fixes the texture conversion problem but causes us to panic on when calling glReadPixels with UNSIGNED_INT_8_8_8_8_REV on Linux.
|
||
Updated•4 years ago
|
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 years ago
|
||
This seems to be working well.
Description
•