Closed Bug 1650486 Opened 4 years ago Closed 4 years ago

Addressbook search glass in searchbox increases its number when customizing

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Version:
78 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
thunderbird_esr68 --- wontfix
thunderbird_esr78 --- fixed
firefox-esr68 --- wontfix
firefox-esr78 --- fixed
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: Paenglab, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

searchbox.jpg
(deleted), image/jpeg
Details
Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-esr78+
Details

+++ This bug was initially created as a clone of Bug #1650342 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36 Edg/83.0.478.58

Steps to reproduce:

Thunderbird 78.0 b4 installation
Checking details

Actual results:

Address book
Toolbar> Right Click> Customize
More icons appear in the search field every time you open or close

See attachment 9161201 [details]

Attached image searchbox.jpg (deleted) —

The problem continues with Ver.78.1.0 and Daily 81.0a1 (2020.08.02).

I can reproduce with the address book search bar. Seems like a toolkit bug.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #9168433 - Attachment description: Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=ntim → Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/integration/autoland/rev/600b0c60d674 guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins

https://hg.mozilla.org/mozilla-central/rev/600b0c60d674

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

What's the plan to get this fixed for TB 78 ESR?

Flags: needinfo?(vseerror)
Flags: needinfo?(rob)
Flags: needinfo?(mkmelin+mozilla)

Once it's on beta after next week, I'll ask for esr approval.

Flags: needinfo?(vseerror)
Flags: needinfo?(rob)
Flags: needinfo?(mkmelin+mozilla)
Regressed by: 1521280
Has Regression Range: --- → yes

Comment on attachment 9168433 [details]
Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Causes bad UI.
  • User impact if declined: In some cases, the search magnifier glass icon gets duplicated.
  • Fix Landed on Version: 81
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small, confined fix. Now has an automated test.
  • String or UUID changes made by this patch: none
Attachment #9168433 - Flags: approval-mozilla-esr78?

Comment on attachment 9168433 [details]
Bug 1650486 - guard search-textbox from multiple connectedCallbacks, so that we don't get multiple search icons. r=bgrins

Approved for 78.3esr.

Attachment #9168433 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
status-thunderbird80: wontfix → ---
status-thunderbird81: fixed → ---
Component: Address Book → XUL Widgets
Product: Thunderbird → Toolkit
Version: 78 → 78 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: