Closed Bug 1650756 Opened 4 years ago Closed 4 years ago

App-provided engines should use the engine configuration when they are updated

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 80
Iteration:
80.1 - June 29 - July 12
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1650756 - Avoid translating any params from the search engine configuration to and from URLSearchParams an additional time. r?daleharvey!
(deleted), text/x-phabricator-request
Details
Bug 1650756 - When upgrading app-provided search engines, ensure the modern configuration is properly re-applied. r?daleharvey!
(deleted), text/x-phabricator-request
Details

I noticed that the app-provided engines do not get the configuration re-applied when they are updated.

This could cause a period of time when the engine is in use but doesn't have the correct parameters applied (I think it would fix itself on restart).

Once bug 1637744 is done (which will make this easier), we should look at obtaining the current configuration and passing that to the update handling routines.

Taking this as I think I need it for bug 1610293, though we should get it done anyway.

Assignee: nobody → standard8
Blocks: 1610293
Status: NEW → ASSIGNED
Iteration: --- → 80.1 - June 29 - July 12
Points: --- → 3

Currently we're converting the configuration url parameters to strings in makeEngineFromConfig via URLSearchParams. We then pass them through URLSearchParams again in _initEngineURLFromMetaData.

Depends on D82525

Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49f8a11bbd1a Avoid translating any params from the search engine configuration to and from URLSearchParams an additional time. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/974e5d55e4f3 When upgrading app-provided search engines, ensure the modern configuration is properly re-applied. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/49f8a11bbd1a
https://hg.mozilla.org/mozilla-central/rev/974e5d55e4f3

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: