Make webExtensions support multiple aliases
Categories
(Firefox :: Search, enhancement, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: daleharvey, Assigned: daleharvey)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We use multiple aliases for yandex + baidu, if we want to use webExtension keywords here we need to add support for multiples
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Hey Shane
This is regarding the search_provider.keyword field being able to handle multiple aliases. Mark and I were wondering, the first implementation of this I just pass through the keyword field and split the string on spaces. So search_provider.keyword = "@duckduckgo @ggd" This makes it simple not having to touch webextensions code, but obviously a little unclean to be doing string operations.
Another choice would be to have the webextensions field support both strings as it does now, and an array search_provider.keyword = ["@duckduckgo", "@ddg"]
Do you have strong opinions either way?
Cheers
Dale
|
||
Comment 3•4 years ago
|
||
Using an array would probably be the cleaner path here.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
Description
•