Slightly tweak content process title
Categories
(DevTools :: Framework, enhancement, P3)
Tracking
(Fission Milestone:M7, firefox87 fixed)
Tracking | Status | |
---|---|---|
firefox87 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 2 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
For now, the content process target title in DevTools is Content Process [pid ${pid}]
,
but there is some different convention on how to label content processes.
about:processes uses ${pid} ${origin} ${remoteType}
about:memory uses ${remoteType} (pid ${pid})
profiler uses ${remoteType} PID: ${pid}
I don't know if there is some other?
What is clear is that we would benefit from showing the remote type and it may be useful to also display the origin, when available.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
The title is implemented over here:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/targets/content-process.js#32-34
FYI, processID
is surprisingly set from here:
https://searchfox.org/mozilla-central/rev/85ae3b911d5fcabd38ef315725df32e25edef83b/devtools/client/fronts/descriptors/process.js#53
(It should probably be passed from the form instead of the descriptor!)
Speaking about the form, this is where you would have to add new attributes if you want to pass some additional data, like the process origin:
https://searchfox.org/mozilla-central/source/devtools/server/actors/targets/content-process.js#141-150
And such additional data would most likely come from Services.appinfo, which exposes:
https://searchfox.org/mozilla-central/source/xpcom/system/nsIXULRuntime.idl#94-115
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Alex, there's a patch here but no reviewers. Could you please finalize this to close the bug?
Also, there is no dt-xx whiteboard tag for this, do we need one for dt-m2 or dt-m3?
Comment 4•4 years ago
|
||
Honza, this DevTools Fission bug has a patch, but no reviewers. I can't tell from comment 1 whether this fix landed in a different bug. Should this bug block shipping Fission? It blocks dt-fission-execution-context meta bug 1605153, but doesn't have a dt-fission
whiteboard tag.
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 6•4 years ago
|
||
bugherder |
Description
•