Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter
Categories
(Core :: Printing: Setup, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
(Whiteboard: [print2020_v80])
Attachments
(3 files)
|
Assignee | |
Comment 1•4 years ago
|
||
All our backends implement nsIPrintSettingsService, so this code is unused.
|
|
Assignee | |
Comment 2•4 years ago
|
||
The fallback code in nsPrintJob::DoCommonPrint to create an nsIPrintSettings if
none is passed in is never used, since all callers pass a settings object.
However, to simplify future changes I'd like nsGlobalWindowOuter::PrintOuter to
stop creating and passing in its own default valued nsIPrintSettings object.
This patch makes the fallback code that DoCommonPrint calls do what
nsGlobalWindowOuter::PrintOuter does, and makes the latter stop passing in a
settings object.
This patch also removes nsIWebBrowserPrint.globalPrintSettings since
nsGlobalWindowOuter::PrintOuter was its only consumer.
Depends on D83267
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/075903436ef2 p1. Remove the code in nsGlobalWindowOuter::PrintOuter for handling failure to get an nsIPrintSettingsService. r=bobowen https://hg.mozilla.org/integration/autoland/rev/d2b66d810ab5 p2. Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter. r=bobowen
|
||
Comment 4•4 years ago
|
||
Backed out 2 changesets for causing failures in test_printpreview.xhtml
Backout link: https://hg.mozilla.org/integration/autoland/rev/52aae6784eb346ee86af8d1f13cdb8965c3a47be
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309523121&repo=autoland&lineNumber=116048
Pushed by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2591c221cff p1. Remove the code in nsGlobalWindowOuter::PrintOuter for handling failure to get an nsIPrintSettingsService. r=bobowen
|
|
Assignee | |
Comment 6•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/autoland/rev/20c29266e1df p2. Fix the print settings creation in the print preview tests. r=hiro https://hg.mozilla.org/integration/autoland/rev/24fb0d980a2e p3. Stop creating an nsIPrintSettings in nsGlobalWindowOuter::PrintOuter. r=bobowen
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d2591c221cff
https://hg.mozilla.org/mozilla-central/rev/20c29266e1df
https://hg.mozilla.org/mozilla-central/rev/24fb0d980a2e
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
Description
•