Firefox fails to play audio (because offerToReceive causes local track event when there's nothing to receive)
Categories
(Core :: WebRTC: Audio/Video, defect, P2)
Tracking
()
People
(Reporter: support, Assigned: bwc)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
application/x-zip-compressed
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr78+
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.116 Safari/537.36
Steps to reproduce:
- Publish audio only WebRTC stream from Firefox in the example attached
- Trying to play this stream
Actual results:
Stream is not playing
Expected results:
Stream should be played (in Chrome for example, it's playing)
Comment 1•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Comment 2•4 years ago
|
||
Thanks for filing this bug! If you could add the relevant code snippet to the description that would help.
(In reply to Nico Grunbaum [:ng, @chew:mozilla.org] from comment #2)
Thanks for filing this bug! If you could add the relevant code snippet to the description that would help.
The code sample is in attachment (see Test_connection.zip)
An audio only stream is publishing and playing in Chrome, but is not playing in Firefox
Comment 5•4 years ago
|
||
Thanks support for the sample, I can repro with it! Firefox fires a streamless video track
event due to offerToReceiveVideo: true
for some reason, even though there's nothing to receive. This unexpectedly resets srcObject
because e.streams[0]
is undefined.
STRs:
- Open https://jsfiddle.net/jib1/yft3x40q/12/ and share mic.
Expected results:
audio track fired with streams = [object MediaStream]
checking
connected
Actual results:
audio track fired with streams = [object MediaStream]
video track fired with streams =
checking
connected
Comment 6•4 years ago
|
||
[Tracking Requested - why for this release]: regression that may cause audio or video to not play on some WebRTC sites.
Regression range: https://phabricator.services.mozilla.com/D64692
Comment 7•4 years ago
|
||
tracking+ for 79, but note that we're already out of betas for this cycle and RC week is next week, so only an extremely low-risk fix would be considered for uplift there at this point. Especially since this is an issues we've already been shipping for a few releases.
Assignee | ||
Comment 8•4 years ago
|
||
Maybe we should check GetActive() on mRecvTrack here...
Assignee | ||
Comment 9•4 years ago
|
||
This is really weird. The same thing doesn't happen when we swap audio/video here.
Assignee | ||
Comment 10•4 years ago
|
||
Found the problem. Running patch through tests now.
Assignee | ||
Comment 11•4 years ago
|
||
Assignee | ||
Comment 12•4 years ago
|
||
Assignee | ||
Comment 13•4 years ago
|
||
Assignee | ||
Comment 14•4 years ago
|
||
Depends on D84206
Assignee | ||
Comment 15•4 years ago
|
||
Try looks ok.
Comment 16•4 years ago
|
||
Updated•4 years ago
|
Comment 18•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d22d5ebae5a
https://hg.mozilla.org/mozilla-central/rev/11ff41f3e95a
Updated•4 years ago
|
Comment 20•4 years ago
|
||
Is this something we should consider for ESR78 uplift?
Assignee | ||
Comment 21•4 years ago
|
||
This seems like a good candidate; it is a simple patch.
Assignee | ||
Comment 22•4 years ago
|
||
Comment on attachment 9164798 [details]
Bug 1652426: Fix bug where ontrack was fired for all receivers if a previously processed receiver had a new track. r?mjf
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a really simple web-compat fix.
- User impact if declined:
- Fix Landed on Version: 80
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String or UUID changes made by this patch: None
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Comment 23•4 years ago
|
||
Comment on attachment 9164797 [details]
Bug 1652426: Test-case for bug. r?jib
Approved for 78.2esr. Thanks for including a test.
Updated•4 years ago
|
Comment 24•4 years ago
|
||
bugherder uplift |
Comment 25•4 years ago
|
||
Confirmed issue with 80.0a1 (2020-07-13) on Windows 10.
Verified with 80.0b8.
Comment 26•4 years ago
|
||
Verified with 78.2ESR as well.
Description
•