Closed Bug 1652566 Opened 4 years ago Closed 4 years ago

[meta] Fix failing DOM Navigation mochitests with Fission enabled

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Fission Milestone M6c

People

(Reporter: neha, Unassigned)

References

Details

(Keywords: meta)

Attachments

(1 file)

Fission Milestone: --- → M6b
Attached file parent.html (deleted) —

The test calls History.go(-1) on a nested iframe. Nesting the test runner in a cross-origin document causes that call to throw a NS_ERROR_FAILURE. I've attached a reduced test case:

I'll figure out where that error is coming from.

We're failing because we don't have a ChildSHistory here: https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/dom/base/nsHistory.cpp#149-153

I imagine this is something that will get fixed by session history in the parent.

M6c since this will need to wait for session history in parent to be complete

Fission Milestone: M6b → M6c
Depends on: 1668911
Depends on: 1599613
Summary: Fix failing DOM Navigation mochitests with cross-origin and Fission enabled → Fix failing DOM Navigation mochitests with Fission enabled
Keywords: meta
Summary: Fix failing DOM Navigation mochitests with Fission enabled → [meta] Fix failing DOM Navigation mochitests with Fission enabled
Depends on: 1677613
Depends on: 1679418
No longer depends on: 1679418

All non-BFCache mochitests for DOM:Navigation are now re-enabled for Fission.
The remaining skipped tests are:
docshell/test/mochitest/test_bfcache_plus_hash.html
docshell/test/mochitest/test_bug1121701.html
docshell/test/mochitest/test_bug590573.html
docshell/test/mochitest/test_bug660404.html
docshell/test/navigation/browser_test_bfcache_eviction.js
docshell/test/navigation/test_bug1364364.html
docshell/test/navigation/test_performance_navigation.html
all of which are BFCache-related and will be handled once we make BFCache work with Fission in Bug 1671510.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: