[meta] Fix failing DOM Navigation mochitests with Fission enabled
Categories
(Core :: DOM: Navigation, defect, P3)
Tracking
()
Fission Milestone | M6c |
People
(Reporter: neha, Unassigned)
References
Details
(Keywords: meta)
Attachments
(1 file)
(deleted),
text/html
|
Details |
Fix all tests that are marked as skipped/failed for Fission
More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests
Reporter | ||
Updated•4 years ago
|
The test calls History.go(-1)
on a nested iframe. Nesting the test runner in a cross-origin document causes that call to throw a NS_ERROR_FAILURE
. I've attached a reduced test case:
- The document at https://bug1652566.bmoattachments.org/attachment.cgi?id=9165215 has a cross-origin frame.
- That cross-origin document has a same-origin frame, which it first navigates and then attempts to call
History.go(-1)
on. - This call throws a
NS_ERROR_FAILURE
.
I'll figure out where that error is coming from.
We're failing because we don't have a ChildSHistory
here: https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/dom/base/nsHistory.cpp#149-153
I imagine this is something that will get fixed by session history in the parent.
Reporter | ||
Comment 4•4 years ago
|
||
M6c since this will need to wait for session history in parent to be complete
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Updated•4 years ago
|
Reporter | ||
Comment 5•4 years ago
|
||
All non-BFCache mochitests for DOM:Navigation are now re-enabled for Fission.
The remaining skipped tests are:
docshell/test/mochitest/test_bfcache_plus_hash.html
docshell/test/mochitest/test_bug1121701.html
docshell/test/mochitest/test_bug590573.html
docshell/test/mochitest/test_bug660404.html
docshell/test/navigation/browser_test_bfcache_eviction.js
docshell/test/navigation/test_bug1364364.html
docshell/test/navigation/test_performance_navigation.html
all of which are BFCache-related and will be handled once we make BFCache work with Fission in Bug 1671510.
Description
•