Closed
Bug 1652685
Opened 4 years ago
Closed 4 years ago
Inline IsPackedArray in CacheIR and Warp
Categories
(Core :: JavaScript Engine: JIT, task, P2)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla80
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
Bug 1652685 part 1 - Make MIsPackedArray not depend on TI for is-array and is-packed checks. r?anba!
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details |
We can do this pretty easily after bug 1651645 removed the TI dependency. A first step would be making Ion's MIsPackedArray more robust/complete so we can use it in Warp.
|
Assignee | |
Updated•4 years ago
|
Severity: normal → N/A
Priority: -- → P2
|
|
Assignee | |
Comment 1•4 years ago
|
||
This makes it easier to reuse in Warp and makes the optimization more resillient
(fixes bug 1383643).
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D84329
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D84330
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/591ba1c5748f
part 1 - Make MIsPackedArray not depend on TI for is-array and is-packed checks. r=anba
https://hg.mozilla.org/integration/autoland/rev/cde69ddc0296
part 2 - Move IsPackedArray code into the MacroAssembler. r=anba
https://hg.mozilla.org/integration/autoland/rev/b32115de87fc
part 3 - Optimize IsPackedArray in CacheIR and Warp. r=anba
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/591ba1c5748f
https://hg.mozilla.org/mozilla-central/rev/cde69ddc0296
https://hg.mozilla.org/mozilla-central/rev/b32115de87fc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in
before you can comment on or make changes to this bug.
Description
•