rustfmt could be a bit more polite
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=python])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
example: https://phabricator.services.mozilla.com/D83583#C2803749NL274
WARNING: Reformat rust
Should be updated to something likke
WARNING: This change does not match the rust coding style. Please run rustfmt on it.
I think the message is coming from:
https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml
we should not update this file but handle it better in the code review bot code:
https://github.com/mozilla/code-review/
Comment 1•4 years ago
|
||
I'm new here and I would like to work on this. do you know which file I should change? I tried to look up and I did not find the file. I tried to search using 'grep -Rl "WARNING" ', "grep - Rl "rust" ' and "grep -Rl "Reformat" '. I found 17 files, none of them seems to be the correct one.
Updated•4 years ago
|
Reporter | ||
Comment 2•4 years ago
|
||
Sorry, I am off currently
Seems that it is this line: https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml#3
no ?
Comment 3•4 years ago
|
||
Reporter | ||
Comment 4•4 years ago
|
||
Nppe, this is the test :)
Comment 5•4 years ago
|
||
Then it's the
https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml#3
Is it okay if we change it here?
Reporter | ||
Comment 6•4 years ago
|
||
Or we create a new field to have the long wording :)
Comment 7•4 years ago
|
||
Updated•4 years ago
|
Comment 8•4 years ago
|
||
This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Comment 9•4 years ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #0)
WARNING: This change does not match the rust coding style. Please run rustfmt on it.
rustfmt
may not be in the PATH
environment string on Windows MozillaBuild command line. I think it should be ./mach lint --fix
that is formatter-agnostic. I had difficulty running Python black formatter for the same reason.
Updated•2 years ago
|
Description
•