Open Bug 1652981 Opened 4 years ago Updated 2 years ago

rustfmt could be a bit more polite

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(Not tracked)

People

(Reporter: Sylvestre, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 file)

example: https://phabricator.services.mozilla.com/D83583#C2803749NL274

WARNING: Reformat rust

Should be updated to something likke

WARNING: This change does not match the rust coding style. Please run rustfmt on it.

I think the message is coming from:
https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml
we should not update this file but handle it better in the code review bot code:
https://github.com/mozilla/code-review/

I'm new here and I would like to work on this. do you know which file I should change? I tried to look up and I did not find the file. I tried to search using 'grep -Rl "WARNING" ', "grep - Rl "rust" ' and "grep -Rl "Reformat" '. I found 17 files, none of them seems to be the correct one.

Flags: needinfo?(sledru)

Sorry, I am off currently
Seems that it is this line: https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml#3
no ?

Flags: needinfo?(sledru)

Nppe, this is the test :)

Or we create a new field to have the long wording :)

Assignee: nobody → philjohnson96
Status: NEW → ASSIGNED

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: philjohnson96 → nobody
Status: ASSIGNED → NEW

(In reply to Sylvestre Ledru [:Sylvestre] from comment #0)

WARNING: This change does not match the rust coding style. Please run rustfmt on it.

rustfmt may not be in the PATH environment string on Windows MozillaBuild command line. I think it should be ./mach lint --fix that is formatter-agnostic. I had difficulty running Python black formatter for the same reason.

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: