Closed
Bug 1653003
Opened 4 years ago
Closed 4 years ago
Port OS.File remove to C++
Categories
(Toolkit Graveyard :: OS.File, task)
Toolkit Graveyard
OS.File
Tracking
(firefox80 fixed)
RESOLVED
FIXED
mozilla80
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: mail, Assigned: mail)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Part of larger work to port OS.File to C++, we need a static method in the IOUtils interface which can remove files and directories.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → krourke
Assignee | ||
Comment 1•4 years ago
|
||
This patch introduces a remove method to the IOUtils interface, which allows
for removing files and directories on disk. It is a simple wrapper around
the nsIFile::Remove method.
Depends on D82982
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dee8cb525a2
Implement IOUtils::remove method r=barret,Gijs
Comment 3•4 years ago
|
||
Backed out changeset 8dee8cb525a2 (bug 1653003) for test_ioutils.html failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/98ed93a8c36a3c541286862ff84d07037b57a713
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309903907&repo=autoland&lineNumber=107014
...
[task 2020-07-15T21:26:00.272Z] 21:26:00 INFO - add_task | Entering test test_remove_recursive
[task 2020-07-15T21:26:00.272Z] 21:26:00 INFO - TEST-PASS | dom/system/tests/test_ioutils.html | Created temporary file at: C:\Users\task_1594847325\AppData\Local\Temp\test_ioutils_remove.tmp.d\top.tmp
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - TEST-PASS | dom/system/tests/test_ioutils.html | Created temporary file at: C:\Users\task_1594847325\AppData\Local\Temp\test_ioutils_remove.tmp.d\child.tmp.d\nested.tmp
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - TEST-PASS | dom/system/tests/test_ioutils.html | Expected file to exist
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - TEST-PASS | dom/system/tests/test_ioutils.html | Expected file to exist
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - Buffered messages finished
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - TEST-UNEXPECTED-FAIL | dom/system/tests/test_ioutils.html | UnknownError: Unexpected error removing file: NS_ERROR_FAILURE - Should not throw any errors
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2205:26
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - GECKO(9204) | MEMORY STAT | vsize 2104268MB | vsizeMaxContiguous 65703636MB | residentFast 321MB | heapAllocated 129MB
[task 2020-07-15T21:26:00.273Z] 21:26:00 INFO - TEST-OK | dom/system/tests/test_ioutils.html | took 292ms
Flags: needinfo?(krourke)
Assignee | ||
Comment 4•4 years ago
|
||
I'm investigating this failure — hope to have a fix soon so we can try to re-land this patch.
Flags: needinfo?(krourke)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb12688fbb61
Implement IOUtils::remove method r=barret,Gijs
Comment 6•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•