Closed Bug 1653164 Opened 4 years ago Closed 2 years ago

Show WebGPU adapter strings in `about:support`

Categories

(Core :: Graphics: WebGPU, enhancement)

Product:
Core
Component:
Graphics: WebGPU
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: kvark, Assigned: ErichDonGubler)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Bug 1653164: feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=#webgpu-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1653164: fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=#webgpu-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1653164: refactor(webgpu): fix `WGPUTextureDescriptor` naming r=#webgpu-reviewers
(deleted), text/x-phabricator-request
Details

We have a lot of information about WebGL1/2. It would make sense to add something for WebGPU.

Depends on: 1808571
Summary: Show WebGPU adapter information in `about:support` → Show WebGPU adapter strings in `about:support`
Assignee: nobody → egubler

We want the equivalent of webgl's lines in about:support:

WebGL 1 Driver Renderer | Google Inc. (Intel) -- ANGLE (Intel, Intel(R) Arc(TM) A770 Graphics Direct3D11 vs_5_0 ps_5_0, D3D11-31.0.101.4314)

We don't want to expose this info to web content yet, so we'll restrict access to privileged contexts, like webgl does.

In webgpu's case, we do want to integrate it into the existing object json thing, though.

From internal chat with :jgilbert: Basically, we want readable contents of wgpu's AdapterInfo, which is accessible via Adapter::get.

Attachment #9332224 - Attachment description: WIP: Bug 1653164: feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` → Bug 1653164: feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=#webgpu-reviewers
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a996e5517aa1 fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert https://hg.mozilla.org/integration/autoland/rev/32ca1ab63d70 feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert https://hg.mozilla.org/integration/autoland/rev/037d37f4eb71 refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

Backed out for causing builds bustages in Adapter.cpp.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: builds/worker/checkouts/gecko/dom/webgpu/Adapter.cpp(144,12): error: no member named 'features' in 'std::shared_ptr<mozilla::webgpu::ffi::WGPUAdapterInformation>'; did you mean to use '->' instead of '.'?
Flags: needinfo?(egubler)

Sigh, looks like the patches from bug 1830336 conflicted, will land again.

Flags: needinfo?(egubler)
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/984a479a81d8 fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert https://hg.mozilla.org/integration/autoland/rev/86be7d9d8fa1 feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert https://hg.mozilla.org/integration/autoland/rev/6f36f0a844be refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert
Flags: needinfo?(egubler)
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91185e96b467 fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert https://hg.mozilla.org/integration/autoland/rev/1b25345f09e5 feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert https://hg.mozilla.org/integration/autoland/rev/938fa5409a7a refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert
Status: NEW → ASSIGNED

Backed out for causing bp-nu bustages in Adapter.h.

Flags: needinfo?(egubler)
Flags: needinfo?(egubler)
Pushed by egubler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/897e87970bee fix(webgpu): actually show props. for `adapter.requestAdapterInfo()` in `about:support` r=webgpu-reviewers,jgilbert https://hg.mozilla.org/integration/autoland/rev/870902dd4347 feat(webgpu): show `wgpu*` fields for WebGPU adapters in `about:support` r=webgpu-reviewers,webidl,saschanaz,jgilbert https://hg.mozilla.org/integration/autoland/rev/9c94ab8b34c0 refactor(webgpu): fix `WGPUTextureDescriptor` naming r=webgpu-reviewers,jgilbert

https://hg.mozilla.org/mozilla-central/rev/897e87970bee
https://hg.mozilla.org/mozilla-central/rev/870902dd4347
https://hg.mozilla.org/mozilla-central/rev/9c94ab8b34c0

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: