Closed Bug 1653186 Opened 4 years ago Closed 4 years ago

Highlighter don't work in about:addons

Categories

(DevTools :: Inspector, defect, P1)

80 Branch
defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox78 unaffected, firefox79 unaffected, firefox80 fixed, firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- unaffected
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: nayinain, Assigned: yzen)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached video Capture 2020-07-16 14-43-58.webm (deleted) —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

  1. Pick an element from about:addons

Actual results:

Highlighter did not appear.

Regression window :

2020-07-16T14:10:18.821000: INFO : platform_buildid: 20200714204954
2020-07-16T14:10:18.821000: INFO : platform_changeset: a05fbae74197b3e9e69f5e0003026451a82bf9cd
2020-07-16T14:10:18.821000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2020-07-16T14:10:18.821000: INFO : platform_version: 80.0a1
2020-07-16T14:10:35.227000: INFO : Narrowed integration regression window from [bfe1e772, 97f04a5d] (3 builds) to [bfe1e772, a05fbae7] (2 builds) (~1 steps left)
2020-07-16T14:10:35.240000: DEBUG : Starting merge handling...
2020-07-16T14:10:35.240000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=a05fbae74197b3e9e69f5e0003026451a82bf9cd&full=1
2020-07-16T14:10:35.240000: DEBUG : redo: attempt 1/3
2020-07-16T14:10:35.240000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=a05fbae74197b3e9e69f5e0003026451a82bf9cd&full=1',), kwargs: {}, attempt #1
2020-07-16T14:10:35.242000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2020-07-16T14:10:36.750000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=a05fbae74197b3e9e69f5e0003026451a82bf9cd&full=1 HTTP/1.1" 200 None
2020-07-16T14:10:36.792000: DEBUG : Found commit message:
Bug 1650094 - making the box model highlighter work in the browser toolbox. r=rcaliman

Differential Revision: https://phabricator.services.mozilla.com/D81476

2020-07-16T14:10:36.792000: DEBUG : Did not find a branch, checking all integration branches
2020-07-16T14:10:36.793000: INFO : The bisection is done.
2020-07-16T14:10:36.793000: INFO : Stopped

Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression
Regressed by: 1650094

Set release status flags based on info from the regressing bug 1650094

Yura, I'm putting this on your radar in case you know of a quick fix considering your experience with bug 1650094.
Let me know if you can't investigate.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(yzenevich)
Priority: -- → P1
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Flags: needinfo?(yzenevich)
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6798cb55d9c9 fix highlighter in about:addons (ensure that the highlighter markup nodes are created using the correct window/document). r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

The regressing changeset was backed out of Firefox 80 in bug 1650094.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: