about:logins loads with no logins due to `login.displayOrigin is null` from an all null/0/"" login
Categories
(Firefox :: about:logins, defect)
Tracking
()
People
(Reporter: aztecjoe, Unassigned)
Details
Attachments
(3 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0
Steps to reproduce:
- Start Firefox using Launcher icon
- Click Open Menu > Logins & Passwords
- In new browser tab open Yahoo Mail and select "Sign in"
- Click "username" field
- Select login from drop-down list -> Next
- Password is supplied -> Next
Actual results:
about:logins page is blank
Yahoo Mail is a saved (synced) bookmark and I can login with the saved (synced) logins.
Expected results:
about:logins page should display my saved logins.
See initial details logged in closed (sorry) bug #1587737
Comment 4•4 years ago
|
||
Hello, can you please attach Browser Console logs? I suspect this is due to E10S being disabled (bug 1592562) which is no longer a supported configuration.
about.logins.log attached as requested
Updated•4 years ago
|
Comment 6•4 years ago
|
||
I'm guessing the problem is:
TypeError: login.displayOrigin is null AboutLoginsParent.jsm:199:15
Is that error something I can do anything about? Could the issue be something to do with the browser being installed as a snap?
Comment 8•4 years ago
|
||
Hello, can you please run the following code in the Browser Console (after enabling the console command line) and provide the output in the bug?
Services.logins.getAllLogins().filter(l => l.displayOrigin === null).map(l => l.origin)
Thanks
Hello, See attached screenshot of the browser console
Comment 10•4 years ago
|
||
Thanks. So somehow you got a login with a null
origin which isn't valid and shouldn't be possible if it was added via Firefox (vs. an external program). Can you run the following code in the same Browser Console (WARNING: it will output the username and password of the login with a null
origin) and then provide the output in the bug after censoring the password and/or username is they aren't dummy values?
console.log(JSON.stringify(Services.logins.getAllLogins().filter(l => l.displayOrigin === null), null, 2))
I'm mostly interested in identifying the source of this login which the httpRealm, formActionOrigin, username and password may tell you. Let me know if you have an idea where this login came from. The timestamps from the output will also give me an idea of how old this invalid login is.
Thanks again.
Reporter | ||
Comment 11•4 years ago
|
||
Hi I ran your code and produced the following:
[
{
"guid": null,
"timeCreated": 0,
"timeLastUsed": 0,
"timePasswordChanged": 0,
"timesUsed": 0,
"username": "",
"password": "",
"displayOrigin": null,
"origin": null,
"hostname": null,
"formActionOrigin": null,
"formSubmitURL": null,
"httpRealm": null,
"usernameField": "",
"passwordField": ""
}
]
From my limited knowledge of Python there is a single dict item in the List with the ** "displayOrigin": null ** item. I reran your code without the filter and was able to see all my saved logins including clear text passwords (ouch). Anyway hope this helps.
Comment 12•4 years ago
|
||
(In reply to aztecjoe from comment #11)
Hi I ran your code and produced the following:
Wow, that's a very invalid login record… everything is null/empty/0. Unfortunately it gives no hints as to its origin so I think for now I will just help you remove it and then if we see other reports we can investigate more.
To remove that invalid login run the following code in the same Browser Console. You may want to make a temporary backup of your logins in advance by using the new export option.
Services.logins.removeLogin(Services.logins.getAllLogins().filter(l => l.displayOrigin === null)[0])
about:logins should load fine after that and we can close the bug. Thanks.
Updated•4 years ago
|
Reporter | ||
Comment 13•4 years ago
|
||
Ran your script:
Services.logins.removeLogin(Services.logins.getAllLogins().filter(l => l.displayOrigin === null)[0])
Got message:
TypeError: login.displayOrigin is null
Refreshed Logins page and all my logins loaded successfully.
Thanks for your help. Much appreciated. Please close the issue.
Updated•4 years ago
|
Description
•