Closed Bug 1654801 Opened 4 years ago Closed 4 years ago

Fix tests to work with update2/oneOffsRefresh prefs enabled

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(3 files)

Bug 1654801 - Part 1 - Fix _getValueFromResult to show alias value on highlight. r?adw!
(deleted), text/x-phabricator-request
Details
Bug 1654801 - Part 2 - Update search results when one-offs are being alt-tabbed. r?adw!
(deleted), text/x-phabricator-request
Details
Bug 1654801 - Part 3 - Fix tests to work with update2/oneOffsRefresh prefs enabled. r?adw!
(deleted), text/x-phabricator-request
Details

Bug 1647888 started the work of adding update2 cases to browser_oneOffs.js. We should fix all urlbar tests so they work with the oneOffsRefresh prefs both on and off.

Severity: -- → S3
Priority: -- → P2
Blocks: 1658326
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 81.2 - Aug 10 - Aug 23
Priority: P2 → P1

I realized this was broken when fixing browser_restoreEmptyInput.js. That test opens Top Sites and keys down to the first result, which is the Amazon search shortcut. It checks that the Urlbar has a value in it. The test broke since token aliases were no longer filling the Urlbar.

I noticed when when working on browser_oneOffs_searchSuggestions > test_selectOneOffThenSuggestion.

Depends on D86765

Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39d16dfdebe7 Part 1 - Fix _getValueFromResult to show alias value on highlight. r=adw https://hg.mozilla.org/integration/autoland/rev/4f7aeba632c5 Part 2 - Update search results when one-offs are being alt-tabbed. r=adw https://hg.mozilla.org/integration/autoland/rev/2c621c03a1b9 Part 3 - Fix tests to work with update2/oneOffsRefresh prefs enabled. r=adw

https://hg.mozilla.org/mozilla-central/rev/39d16dfdebe7
https://hg.mozilla.org/mozilla-central/rev/4f7aeba632c5
https://hg.mozilla.org/mozilla-central/rev/2c621c03a1b9

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: