Open
Bug 1654883
Opened 4 years ago
Updated 3 years ago
--disable-icf doesn't seem to disable identical code folding in rust
Categories
(Firefox Build System :: General, defect, P4)
Firefox Build System
General
Tracking
(Not tracked)
NEW
People
(Reporter: jrmuizel, Unassigned)
References
Details
I have this showing up as calls to raw_vec::RawVec<[SomeType]>::reserve that's different from the actual type being used. I've run into this when trying to diagnose some leaks in WPA/DMD
I suspect that more likely your bug is that --disable-icf doesn't work on Windows.
The place where we request ICF on Windows (https://searchfox.org/mozilla-central/rev/227f22acef5c4865503bde9f835452bf38332c8e/python/mozbuild/mozbuild/frontend/context.py#460) is quite far away from the place where we check for --disable-icf (https://searchfox.org/mozilla-central/rev/227f22acef5c4865503bde9f835452bf38332c8e/build/autoconf/compiler-opts.m4#81).
|
Reporter | |
Comment 2•4 years ago
|
||
That seems likely.
|
||
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P4
You need to log in
before you can comment on or make changes to this bug.
Description
•