Closed Bug 1655180 Opened 4 years ago Closed 4 years ago

Can't run raptor on MacOS

Categories

(Testing :: Raptor, defect, P1)

defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 unaffected, firefox79 unaffected, firefox80 disabled, firefox81 affected)

RESOLVED WORKSFORME
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- unaffected
firefox80 --- disabled
firefox81 --- affected

People

(Reporter: agi, Assigned: hamzah18051)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

These command fails on my machine:

./mach raptor --test raptor-tp6-amazon-firefox --verbose
...
19:43:10    FATAL - Can't find the virtualenv module
19:43:10    FATAL - Running post_fatal callback...
19:43:10    FATAL - Exiting -1

I tracked it down to a regression from Bug 1408051. Looks like {abs_src_dir} is not defined in my build: https://searchfox.org/mozilla-central/rev/828f2319c0195d7f561ed35533aef6fe183e68e3/testing/mozharness/mozharness/base/python.py#365-378

Flags: needinfo?(hamzah18051)
Flags: needinfo?(ahal)

From what I could understand is that the abs_src_dir key is not set here(https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/raptor.py#446-455) that's why the command is failing because it's not able to find the virtualenv module due to a KeyError

Flags: needinfo?(hamzah18051)
Attached file possible_fix (deleted) —

I think this might work but it would be great if :ahal could also take a look at it

Severity: -- → S1
Priority: -- → P1

The fix in comment 2 looks reasonable to me. Hamzah, were you able to reproduce and confirm the fix works? Mind pushing a revision to phabricator? Thanks for looking into it!

Flags: needinfo?(ahal) → needinfo?(hamzah18051)

Yeah, I was able to reproduce it on running the raptor command provided. The fix worked for me on mac, I even tested it on windows.

Flags: needinfo?(hamzah18051)
Attached file Bug 1655180 - fix raptor on mac (deleted) —
Assignee: nobody → hamzah18051
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1408051

:kimberlythegeek can you run raptor on your mac system?

Flags: needinfo?(ksereduck)
Flags: needinfo?(gmierz2)

I can confirm that I don't hit this issue on Linux anymore (I hit the same issue on that platform).

Flags: needinfo?(gmierz2)

Tested on MacOS 10.15.6 and did not experience any issues

Flags: needinfo?(ksereduck)

Great, so it's working now. Closing this bug.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Flags: needinfo?(hamzah18051)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: