Closed Bug 1655237 Opened 4 years ago Closed 4 years ago

AsyncPanZoomController::HandleDragEvent wrongly clears the state for all mouse ups

Categories

(Core :: Panning and Zooming, defect)

defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

AsyncPanZoomController::HandleDragEvent calls SetState(NOTHING) for every mouse up event. So if a user clicks on a scrollbar track (but not the thumb) we start a smooth scroll animation and set the state as smooth scroll to do the page scroll, but when we receive the mouse up we clear the state even though the animation still proceeds (in most cases the animation still runs to completion fine).

If a user clicks on a scrollbar track (but not the thumb) we start a smooth scroll animation and set the state as smooth scroll to do the page scroll, but when we receive the mouse up we clear the state even though the animation still proceeds (in most cases the animation still runs to completion fine).

Depends on D84902

Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2964ee0c4371 In AsyncPanZoomController::HandleDragEvent only clear the state on mouse ups if we were in the scrolbar dragging state. r=botond
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: